Please check for false positives in the output before submitting a patch. When using "patch" mode, carefully review the patch before submitting it. /home/cocci/testing/drivers/net/ethernet/broadcom/bnxt/bnxt.c:5426:6-25: WARNING: atomic_dec_and_test variation before object free at line 5433. warning: line 134: should no_llseek be a metavariable? warning: line 141: should noop_llseek be a metavariable? warning: line 223: should nonseekable_open be a metavariable? warning: line 290: should nonseekable_open be a metavariable? warning: line 338: should nonseekable_open be a metavariable? /home/cocci/testing/drivers/net/ethernet/intel/i40e/i40e_main.c:15849:2-8: ERROR: missing iounmap; ioremap on line 15696 and execution via conditional on line 15848 /home/cocci/testing/drivers/net/wwan/t7xx/t7xx_modem_ops.c:506:6-11: ERROR: invalid reference to the index variable of the iterator on line 483 /home/cocci/testing/drivers/net/wwan/t7xx/t7xx_modem_ops.c:528:7-12: ERROR: invalid reference to the index variable of the iterator on line 483 /home/cocci/testing/drivers/net/dsa/mv88e6xxx/chip.c:1509:5-7: ERROR: invalid reference to the index variable of the iterator on line 1478 /home/cocci/testing/drivers/net/dsa/mv88e6xxx/chip.c:1509:38-40: ERROR: invalid reference to the index variable of the iterator on line 1478 /home/cocci/testing/drivers/net/dsa/mv88e6xxx/chip.c:1509:5-7: ERROR: invalid reference to the index variable of the iterator on line 1490 /home/cocci/testing/drivers/net/dsa/mv88e6xxx/chip.c:1509:38-40: ERROR: invalid reference to the index variable of the iterator on line 1490 /home/cocci/testing/drivers/net/ethernet/broadcom/genet/bcmgenet.c:1474:5-13: ERROR: invalid reference to the index variable of the iterator on line 1452 /home/cocci/testing/drivers/net/ethernet/intel/ice/ice_main.c:9097:2-8: preceding lock on line 9077 /home/cocci/testing/drivers/net/ethernet/mellanox/mlx4/port.c:338:1-7: preceding lock on line 204 /home/cocci/testing/drivers/net/ethernet/mellanox/mlx4/port.c:737:1-7: preceding lock on line 599 /home/cocci/testing/drivers/net/ethernet/mellanox/mlx4/port.c:532:1-7: preceding lock on line 490 /home/cocci/testing/drivers/net/ethernet/mellanox/mlx4/port.c:447:0-1: preceding lock on line 400 /home/cocci/testing/drivers/net/ethernet/mellanox/mlx4/port.c:824:0-1: preceding lock on line 775 /home/cocci/testing/drivers/net/wireless/ti/wlcore/main.c:2362:1-7: preceding lock on line 2332 /home/cocci/testing/net/smc/af_smc.c:2555:0-1: preceding lock on line 2490 /home/cocci/testing/mm/page_alloc.c:5858:2-8: WARNING: do_div() does a 64-by-32 division, please consider using div64_ul instead. /home/cocci/testing/include/linux/mlx5/mlx5_ifc.h:414:12-28: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) /home/cocci/testing/include/linux/mlx5/mlx5_ifc.h:3552:11-19: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) /home/cocci/testing/include/linux/mlx5/mlx5_ifc.h:4616:12-17: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) /home/cocci/testing/include/linux/mlx5/mlx5_ifc.h:5512:12-15: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) /home/cocci/testing/include/linux/mlx5/mlx5_ifc.h:5516:30-33: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) /home/cocci/testing/include/linux/mlx5/mlx5_ifc.h:6181:12-25: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) /home/cocci/testing/include/linux/mlx5/mlx5_ifc.h:6606:12-29: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) /home/cocci/testing/include/linux/mlx5/mlx5_ifc.h:7219:12-16: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) /home/cocci/testing/include/linux/mlx5/mlx5_ifc.h:7249:12-24: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) /home/cocci/testing/include/linux/mlx5/mlx5_ifc.h:7359:12-20: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) /home/cocci/testing/include/linux/mlx5/mlx5_ifc.h:7429:12-15: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) /home/cocci/testing/include/linux/mlx5/mlx5_ifc.h:7476:12-26: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) /home/cocci/testing/include/linux/mlx5/mlx5_ifc.h:10182:12-35: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) /home/cocci/testing/include/linux/mlx5/mlx5_ifc.h:10246:12-34: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) /home/cocci/testing/include/linux/mlx5/mlx5_ifc.h:10327:12-38: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) /home/cocci/testing/include/linux/mlx5/mlx5_ifc.h:10332:12-27: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) /home/cocci/testing/include/linux/mlx5/mlx5_ifc.h:10427:12-26: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) /home/cocci/testing/include/linux/mlx5/mlx5_ifc.h:10530:12-17: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) /home/cocci/testing/include/linux/mlx5/mlx5_ifc.h:10563:12-21: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) /home/cocci/testing/include/linux/mlx5/mlx5_ifc.h:10609:12-17: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) /home/cocci/testing/include/linux/mlx5/mlx5_ifc.h:12663:43-54: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) /home/cocci/testing/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c:120:6-9: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) /home/cocci/testing/drivers/net/ethernet/intel/i40e/i40e_dcb.h:113:4-11: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) /home/cocci/testing/drivers/net/ethernet/intel/i40e/i40e_dcb.h:135:4-11: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) /home/cocci/testing/drivers/net/ethernet/intel/ice/ice_main.c:1345:12-13: WARNING opportunity for min() /home/cocci/testing/net/core/dev.c:1179:12-13: WARNING opportunity for min() /home/cocci/testing/drivers/net/virtio_net.c:1423:21-22: WARNING opportunity for max() /home/cocci/testing/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c:1956:17-18: WARNING opportunity for min() /home/cocci/testing/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c:1271:17-18: WARNING opportunity for min() /home/cocci/testing/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c:1319:17-18: WARNING opportunity for min() /home/cocci/testing/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c:2640:17-18: WARNING opportunity for min() /home/cocci/testing/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c:1295:17-18: WARNING opportunity for min() /home/cocci/testing/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c:2157:17-18: WARNING opportunity for min() /home/cocci/testing/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c:3582:17-18: WARNING opportunity for min() /home/cocci/testing/drivers/net/dsa/mv88e6xxx/chip.c:6725:17-19: WARNING opportunity for min() /home/cocci/testing/drivers/net/ethernet/mellanox/mlx4/main.c:4572:12-13: WARNING opportunity for min() /home/cocci/testing/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:2922:42-43: WARNING opportunity for max() /home/cocci/testing/net/smc/smc_ism.h:66:11-12: WARNING opportunity for min() /home/cocci/testing/drivers/net/ethernet/intel/ice/ice_devlink.c:481:8-49: WARNING avoid newline at end of message in NL_SET_ERR_MSG_MOD /home/cocci/testing/drivers/net/ethernet/intel/ice/ice_devlink.c:491:8-46: WARNING avoid newline at end of message in NL_SET_ERR_MSG_MOD /home/cocci/testing/drivers/net/ethernet/intel/ice/ice_devlink.c:486:8-44: WARNING avoid newline at end of message in NL_SET_ERR_MSG_MOD /home/cocci/testing/drivers/net/ieee802154/ca8210.c:202:59-60: WARNING: sum of probable bitmasks, consider | /home/cocci/testing/drivers/net/ieee802154/ca8210.c:203:57-58: WARNING: sum of probable bitmasks, consider | /home/cocci/testing/drivers/net/ieee802154/ca8210.c:204:59-60: WARNING: sum of probable bitmasks, consider | /home/cocci/testing/drivers/net/ieee802154/ca8210.c:209:57-58: WARNING: sum of probable bitmasks, consider | /home/cocci/testing/drivers/net/ieee802154/ca8210.c:210:57-58: WARNING: sum of probable bitmasks, consider | /home/cocci/testing/drivers/net/ieee802154/ca8210.c:215:60-61: WARNING: sum of probable bitmasks, consider | /home/cocci/testing/drivers/net/ieee802154/ca8210.c:216:57-58: WARNING: sum of probable bitmasks, consider | /home/cocci/testing/drivers/net/ethernet/renesas/ravb_main.c:561:36-37: WARNING: sum of probable bitmasks, consider | /home/cocci/testing/drivers/net/ethernet/mellanox/mlx4/port.c:1823:5-8: Unneeded variable: "err". Return "0" on line 1825 /home/cocci/testing/drivers/net/ethernet/mellanox/mlx4/port.c:1843:5-8: Unneeded variable: "err". Return "0" on line 1845 /home/cocci/testing/drivers/net/ethernet/intel/idpf/idpf.h:709:1-27: duplicated argument to & or | /home/cocci/testing/drivers/net/ethernet/intel/idpf/idpf.h:714:1-27: duplicated argument to & or | /home/cocci/testing/drivers/net/ethernet/xircom/xirc2ps_cs.c:375:29-30: duplicated argument to & or |