New warnings added --- /home/cocci/outputs/results/454042/old-filtered 2024-02-06 10:44:52.933483473 -0800 +++ /home/cocci/outputs/results/454042/new-filtered 2024-02-06 10:44:52.943483525 -0800 @@ -5 +5 @@ -/home/cocci/testing/drivers/net/ethernet/broadcom/bnxt/bnxt.c:5337:6-25: WARNING: atomic_dec_and_test variation before object free at line 5344. +/home/cocci/testing/drivers/net/ethernet/broadcom/bnxt/bnxt.c:5426:6-25: WARNING: atomic_dec_and_test variation before object free at line 5433. @@ -11 +11,3 @@ -/home/cocci/testing/drivers/net/ethernet/intel/i40e/i40e_main.c:15853:2-8: ERROR: missing iounmap; ioremap on line 15700 and execution via conditional on line 15852 +/home/cocci/testing/drivers/net/ethernet/intel/i40e/i40e_main.c:15849:2-8: ERROR: missing iounmap; ioremap on line 15696 and execution via conditional on line 15848 +/home/cocci/testing/drivers/net/wwan/t7xx/t7xx_modem_ops.c:506:6-11: ERROR: invalid reference to the index variable of the iterator on line 483 +/home/cocci/testing/drivers/net/wwan/t7xx/t7xx_modem_ops.c:528:7-12: ERROR: invalid reference to the index variable of the iterator on line 483 @@ -16,4 +18,2 @@ -/home/cocci/testing/drivers/net/ethernet/broadcom/genet/bcmgenet.c:1476:5-13: ERROR: invalid reference to the index variable of the iterator on line 1454 -/home/cocci/testing/drivers/net/wwan/t7xx/t7xx_modem_ops.c:500:6-11: ERROR: invalid reference to the index variable of the iterator on line 477 -/home/cocci/testing/drivers/net/wwan/t7xx/t7xx_modem_ops.c:522:7-12: ERROR: invalid reference to the index variable of the iterator on line 477 -/home/cocci/testing/drivers/net/ethernet/intel/ice/ice_main.c:9162:2-8: preceding lock on line 9142 +/home/cocci/testing/drivers/net/ethernet/broadcom/genet/bcmgenet.c:1474:5-13: ERROR: invalid reference to the index variable of the iterator on line 1452 +/home/cocci/testing/drivers/net/ethernet/intel/ice/ice_main.c:9097:2-8: preceding lock on line 9077 @@ -25 +24,0 @@ -/home/cocci/testing/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c:3766:1-7: preceding lock on line 3714 @@ -28,2 +27 @@ -/home/cocci/testing/mm/page_alloc.c:5848:2-8: WARNING: do_div() does a 64-by-32 division, please consider using div64_ul instead. -/home/cocci/testing/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c:120:6-9: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) +/home/cocci/testing/mm/page_alloc.c:5858:2-8: WARNING: do_div() does a 64-by-32 division, please consider using div64_ul instead. @@ -50 +48,2 @@ -/home/cocci/testing/include/linux/mlx5/mlx5_ifc.h:12662:43-54: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) +/home/cocci/testing/include/linux/mlx5/mlx5_ifc.h:12663:43-54: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) +/home/cocci/testing/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c:120:6-9: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) @@ -53,2 +52,10 @@ -/home/cocci/testing/drivers/net/ethernet/mellanox/mlx4/main.c:4572:12-13: WARNING opportunity for min() -/home/cocci/testing/drivers/net/virtio_net.c:1403:21-22: WARNING opportunity for max() +/home/cocci/testing/drivers/net/ethernet/intel/ice/ice_main.c:1345:12-13: WARNING opportunity for min() +/home/cocci/testing/net/core/dev.c:1179:12-13: WARNING opportunity for min() +/home/cocci/testing/drivers/net/virtio_net.c:1423:21-22: WARNING opportunity for max() +/home/cocci/testing/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c:1956:17-18: WARNING opportunity for min() +/home/cocci/testing/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c:1271:17-18: WARNING opportunity for min() +/home/cocci/testing/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c:1319:17-18: WARNING opportunity for min() +/home/cocci/testing/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c:2640:17-18: WARNING opportunity for min() +/home/cocci/testing/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c:1295:17-18: WARNING opportunity for min() +/home/cocci/testing/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c:2157:17-18: WARNING opportunity for min() +/home/cocci/testing/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c:3582:17-18: WARNING opportunity for min() @@ -55,0 +63,2 @@ +/home/cocci/testing/drivers/net/ethernet/mellanox/mlx4/main.c:4572:12-13: WARNING opportunity for min() +/home/cocci/testing/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:2922:42-43: WARNING opportunity for max() @@ -57,6 +66,3 @@ -/home/cocci/testing/net/core/dev.c:1179:12-13: WARNING opportunity for min() -/home/cocci/testing/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:2924:42-43: WARNING opportunity for max() -/home/cocci/testing/drivers/net/ethernet/intel/ice/ice_main.c:1345:12-13: WARNING opportunity for min() -/home/cocci/testing/drivers/net/ethernet/intel/ice/ice_devlink.c:467:8-49: WARNING avoid newline at end of message in NL_SET_ERR_MSG_MOD -/home/cocci/testing/drivers/net/ethernet/intel/ice/ice_devlink.c:477:8-46: WARNING avoid newline at end of message in NL_SET_ERR_MSG_MOD -/home/cocci/testing/drivers/net/ethernet/intel/ice/ice_devlink.c:472:8-44: WARNING avoid newline at end of message in NL_SET_ERR_MSG_MOD +/home/cocci/testing/drivers/net/ethernet/intel/ice/ice_devlink.c:481:8-49: WARNING avoid newline at end of message in NL_SET_ERR_MSG_MOD +/home/cocci/testing/drivers/net/ethernet/intel/ice/ice_devlink.c:491:8-46: WARNING avoid newline at end of message in NL_SET_ERR_MSG_MOD +/home/cocci/testing/drivers/net/ethernet/intel/ice/ice_devlink.c:486:8-44: WARNING avoid newline at end of message in NL_SET_ERR_MSG_MOD @@ -70 +76 @@ -/home/cocci/testing/drivers/net/ethernet/renesas/ravb_main.c:529:36-37: WARNING: sum of probable bitmasks, consider | +/home/cocci/testing/drivers/net/ethernet/renesas/ravb_main.c:561:36-37: WARNING: sum of probable bitmasks, consider | @@ -72,0 +79,2 @@ +/home/cocci/testing/drivers/net/ethernet/intel/idpf/idpf.h:709:1-27: duplicated argument to & or | +/home/cocci/testing/drivers/net/ethernet/intel/idpf/idpf.h:714:1-27: duplicated argument to & or | @@ -74,2 +81,0 @@ -/home/cocci/testing/drivers/net/ethernet/intel/idpf/idpf.h:698:1-27: duplicated argument to & or | -/home/cocci/testing/drivers/net/ethernet/intel/idpf/idpf.h:703:1-27: duplicated argument to & or |