Please check for false positives in the output before submitting a patch. When using "patch" mode, carefully review the patch before submitting it. warning: line 134: should no_llseek be a metavariable? warning: line 141: should noop_llseek be a metavariable? warning: line 223: should nonseekable_open be a metavariable? warning: line 290: should nonseekable_open be a metavariable? warning: line 338: should nonseekable_open be a metavariable? /home/cocci/testing/drivers/net/ethernet/intel/i40e/i40e_main.c:15849:2-8: ERROR: missing iounmap; ioremap on line 15696 and execution via conditional on line 15848 /home/cocci/testing/drivers/net/phy/mdio_bus.c:469:1-33: WARNING: Function "for_each_available_child_of_node" should have of_node_put() before return around line 499. /home/cocci/testing/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c:12984:27-31: ERROR: invalid reference to the index variable of the iterator on line 12973 /home/cocci/testing/drivers/net/tun.c:2036:1-7: preceding lock on line 1840 /home/cocci/testing/net/smc/af_smc.c:2556:0-1: preceding lock on line 2491 /home/cocci/testing/drivers/net/ethernet/intel/ice/ice_ethtool.c:3691:1-7: preceding lock on line 3666 /home/cocci/testing/drivers/net/ethernet/intel/ice/ice_main.c:9103:2-8: preceding lock on line 9083 /home/cocci/testing/drivers/net/ethernet/nvidia/forcedeth.c:3474:8-10: WARNING: possible condition with no effect (if == else) /home/cocci/testing/drivers/net/ethernet/intel/ice/ice_devlink.c:481:8-49: WARNING avoid newline at end of message in NL_SET_ERR_MSG_MOD /home/cocci/testing/drivers/net/ethernet/intel/ice/ice_devlink.c:491:8-46: WARNING avoid newline at end of message in NL_SET_ERR_MSG_MOD /home/cocci/testing/drivers/net/ethernet/intel/ice/ice_devlink.c:486:8-44: WARNING avoid newline at end of message in NL_SET_ERR_MSG_MOD /home/cocci/testing/drivers/net/ethernet/renesas/ravb_main.c:560:36-37: WARNING: sum of probable bitmasks, consider |