New warnings added --- /home/cocci/outputs/results/490401/old-filtered 2024-03-02 18:21:19.649040603 -0800 +++ /home/cocci/outputs/results/490401/new-filtered 2024-03-02 18:21:19.659040646 -0800 @@ -7 +7 @@ -/home/cocci/testing/drivers/net/ipa/ipa_interrupt.c:249:2-9: line 249 is redundant because platform_get_irq() already prints an error +/home/cocci/testing/drivers/net/ipa/ipa_interrupt.c:300:2-9: line 300 is redundant because platform_get_irq() already prints an error @@ -14,2 +14,2 @@ -/home/cocci/testing/kernel/bpf/btf.c:4651:6-7: ERROR: iterator variable bound on line 4649 cannot be NULL -/home/cocci/testing/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_rx.c:770:1-8: ERROR: invalid reference to the index variable of the iterator on line 740 +/home/cocci/testing/kernel/bpf/btf.c:4658:6-7: ERROR: iterator variable bound on line 4656 cannot be NULL +/home/cocci/testing/net/core/gro.c:38:25-29: ERROR: invalid reference to the index variable of the iterator on line 34 @@ -18,5 +18,6 @@ -/home/cocci/testing/net/core/gro.c:38:25-29: ERROR: invalid reference to the index variable of the iterator on line 34 -/home/cocci/testing/drivers/net/ethernet/intel/ice/ice_main.c:9104:2-8: preceding lock on line 9084 -/home/cocci/testing/kernel/bpf/btf.c:8604:1-7: preceding lock on line 8558 -/home/cocci/testing/tools/testing/selftests/bpf/progs/profiler.inc.h:136:40-41: WARNING: Use ARRAY_SIZE -/home/cocci/testing/tools/lib/bpf/libbpf.c:1825:43-48: WARNING: conversion to bool not needed here +/home/cocci/testing/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_rx.c:768:1-8: ERROR: invalid reference to the index variable of the iterator on line 738 +/home/cocci/testing/drivers/net/ethernet/intel/ice/ice_main.c:9098:2-8: preceding lock on line 9078 +/home/cocci/testing/kernel/bpf/btf.c:8727:1-7: preceding lock on line 8681 +/home/cocci/testing/tools/testing/selftests/bpf/progs/profiler.inc.h:137:40-41: WARNING: Use ARRAY_SIZE +/home/cocci/testing/tools/testing/selftests/bpf/progs/profiler.inc.h:137:40-41: WARNING: Use ARRAY_SIZE +/home/cocci/testing/tools/lib/bpf/libbpf.c:1856:43-48: WARNING: conversion to bool not needed here @@ -24,4 +24,0 @@ -/home/cocci/testing/tools/testing/selftests/bpf/progs/test_lwt_seg6local.c:44:19-27: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) -/home/cocci/testing/tools/testing/selftests/bpf/progs/test_lwt_seg6local.c:50:15-20: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) -/home/cocci/testing/tools/testing/selftests/bpf/progs/test_seg6_loop.c:44:19-27: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) -/home/cocci/testing/tools/testing/selftests/bpf/progs/test_seg6_loop.c:50:15-20: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) @@ -42,7 +39,11 @@ -/home/cocci/testing/include/linux/mlx5/mlx5_ifc.h:10327:12-38: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) -/home/cocci/testing/include/linux/mlx5/mlx5_ifc.h:10332:12-27: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) -/home/cocci/testing/include/linux/mlx5/mlx5_ifc.h:10427:12-26: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) -/home/cocci/testing/include/linux/mlx5/mlx5_ifc.h:10530:12-17: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) -/home/cocci/testing/include/linux/mlx5/mlx5_ifc.h:10563:12-21: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) -/home/cocci/testing/include/linux/mlx5/mlx5_ifc.h:10609:12-17: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) -/home/cocci/testing/include/linux/mlx5/mlx5_ifc.h:12663:43-54: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) +/home/cocci/testing/include/linux/mlx5/mlx5_ifc.h:10331:12-38: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) +/home/cocci/testing/include/linux/mlx5/mlx5_ifc.h:10336:12-27: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) +/home/cocci/testing/include/linux/mlx5/mlx5_ifc.h:10431:12-26: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) +/home/cocci/testing/include/linux/mlx5/mlx5_ifc.h:10534:12-17: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) +/home/cocci/testing/include/linux/mlx5/mlx5_ifc.h:10567:12-21: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) +/home/cocci/testing/include/linux/mlx5/mlx5_ifc.h:10613:12-17: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) +/home/cocci/testing/include/linux/mlx5/mlx5_ifc.h:12667:43-54: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) +/home/cocci/testing/tools/testing/selftests/bpf/progs/test_seg6_loop.c:46:19-27: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) +/home/cocci/testing/tools/testing/selftests/bpf/progs/test_seg6_loop.c:52:15-20: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) +/home/cocci/testing/tools/testing/selftests/bpf/progs/test_lwt_seg6local.c:46:19-27: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) +/home/cocci/testing/tools/testing/selftests/bpf/progs/test_lwt_seg6local.c:52:15-20: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) @@ -50,26 +51,26 @@ -/home/cocci/testing/tools/testing/selftests/bpf/progs/test_xdp_noinline.c:408:24-25: WARNING opportunity for swap() -/home/cocci/testing/tools/testing/selftests/bpf/progs/profiler.inc.h:360:18-22: WARNING comparing pointer to 0, suggest !E -/home/cocci/testing/tools/testing/selftests/bpf/progs/profiler.inc.h:535:23-27: WARNING comparing pointer to 0, suggest !E -/home/cocci/testing/tools/testing/selftests/bpf/progs/profiler.inc.h:542:21-25: WARNING comparing pointer to 0, suggest !E -/home/cocci/testing/tools/testing/selftests/bpf/progs/profiler.inc.h:625:19-23: WARNING comparing pointer to 0, suggest !E -/home/cocci/testing/tools/testing/selftests/bpf/progs/profiler.inc.h:625:40-44: WARNING comparing pointer to 0, suggest !E -/home/cocci/testing/tools/testing/selftests/bpf/progs/profiler.inc.h:385:19-23: WARNING comparing pointer to 0, suggest !E -/home/cocci/testing/tools/testing/selftests/bpf/progs/profiler.inc.h:392:20-24: WARNING comparing pointer to 0, suggest !E -/home/cocci/testing/tools/testing/selftests/bpf/progs/profiler.inc.h:517:21-25: WARNING comparing pointer to 0 -/home/cocci/testing/tools/testing/selftests/bpf/progs/profiler.inc.h:269:17-21: WARNING comparing pointer to 0 -/home/cocci/testing/tools/testing/selftests/bpf/progs/profiler.inc.h:688:29-33: WARNING comparing pointer to 0 -/home/cocci/testing/tools/testing/selftests/bpf/progs/profiler.inc.h:360:18-22: WARNING comparing pointer to 0 -/home/cocci/testing/tools/testing/selftests/bpf/progs/profiler.inc.h:517:21-25: WARNING comparing pointer to 0 -/home/cocci/testing/tools/testing/selftests/bpf/progs/profiler.inc.h:535:23-27: WARNING comparing pointer to 0 -/home/cocci/testing/tools/testing/selftests/bpf/progs/profiler.inc.h:542:21-25: WARNING comparing pointer to 0 -/home/cocci/testing/tools/testing/selftests/bpf/progs/profiler.inc.h:764:13-17: WARNING comparing pointer to 0 -/home/cocci/testing/tools/testing/selftests/bpf/progs/profiler.inc.h:269:17-21: WARNING comparing pointer to 0 -/home/cocci/testing/tools/testing/selftests/bpf/progs/profiler.inc.h:688:29-33: WARNING comparing pointer to 0 -/home/cocci/testing/tools/testing/selftests/bpf/progs/profiler.inc.h:625:19-23: WARNING comparing pointer to 0 -/home/cocci/testing/tools/testing/selftests/bpf/progs/profiler.inc.h:625:40-44: WARNING comparing pointer to 0 -/home/cocci/testing/tools/testing/selftests/bpf/progs/profiler.inc.h:637:24-28: WARNING comparing pointer to 0 -/home/cocci/testing/tools/testing/selftests/bpf/progs/profiler.inc.h:385:19-23: WARNING comparing pointer to 0 -/home/cocci/testing/tools/testing/selftests/bpf/progs/profiler.inc.h:389:19-23: WARNING comparing pointer to 0 -/home/cocci/testing/tools/testing/selftests/bpf/progs/profiler.inc.h:392:20-24: WARNING comparing pointer to 0 -/home/cocci/testing/tools/testing/selftests/bpf/progs/profiler.inc.h:402:20-24: WARNING comparing pointer to 0 -/home/cocci/testing/tools/testing/selftests/bpf/progs/profiler.inc.h:434:20-24: WARNING comparing pointer to 0 +/home/cocci/testing/tools/testing/selftests/bpf/progs/test_xdp_noinline.c:409:24-25: WARNING opportunity for swap() +/home/cocci/testing/tools/testing/selftests/bpf/progs/profiler.inc.h:361:18-22: WARNING comparing pointer to 0, suggest !E +/home/cocci/testing/tools/testing/selftests/bpf/progs/profiler.inc.h:536:23-27: WARNING comparing pointer to 0, suggest !E +/home/cocci/testing/tools/testing/selftests/bpf/progs/profiler.inc.h:543:21-25: WARNING comparing pointer to 0, suggest !E +/home/cocci/testing/tools/testing/selftests/bpf/progs/profiler.inc.h:626:19-23: WARNING comparing pointer to 0, suggest !E +/home/cocci/testing/tools/testing/selftests/bpf/progs/profiler.inc.h:626:40-44: WARNING comparing pointer to 0, suggest !E +/home/cocci/testing/tools/testing/selftests/bpf/progs/profiler.inc.h:386:19-23: WARNING comparing pointer to 0, suggest !E +/home/cocci/testing/tools/testing/selftests/bpf/progs/profiler.inc.h:393:20-24: WARNING comparing pointer to 0, suggest !E +/home/cocci/testing/tools/testing/selftests/bpf/progs/profiler.inc.h:518:21-25: WARNING comparing pointer to 0 +/home/cocci/testing/tools/testing/selftests/bpf/progs/profiler.inc.h:270:17-21: WARNING comparing pointer to 0 +/home/cocci/testing/tools/testing/selftests/bpf/progs/profiler.inc.h:689:29-33: WARNING comparing pointer to 0 +/home/cocci/testing/tools/testing/selftests/bpf/progs/profiler.inc.h:361:18-22: WARNING comparing pointer to 0 +/home/cocci/testing/tools/testing/selftests/bpf/progs/profiler.inc.h:518:21-25: WARNING comparing pointer to 0 +/home/cocci/testing/tools/testing/selftests/bpf/progs/profiler.inc.h:536:23-27: WARNING comparing pointer to 0 +/home/cocci/testing/tools/testing/selftests/bpf/progs/profiler.inc.h:543:21-25: WARNING comparing pointer to 0 +/home/cocci/testing/tools/testing/selftests/bpf/progs/profiler.inc.h:765:13-17: WARNING comparing pointer to 0 +/home/cocci/testing/tools/testing/selftests/bpf/progs/profiler.inc.h:270:17-21: WARNING comparing pointer to 0 +/home/cocci/testing/tools/testing/selftests/bpf/progs/profiler.inc.h:689:29-33: WARNING comparing pointer to 0 +/home/cocci/testing/tools/testing/selftests/bpf/progs/profiler.inc.h:626:19-23: WARNING comparing pointer to 0 +/home/cocci/testing/tools/testing/selftests/bpf/progs/profiler.inc.h:626:40-44: WARNING comparing pointer to 0 +/home/cocci/testing/tools/testing/selftests/bpf/progs/profiler.inc.h:638:24-28: WARNING comparing pointer to 0 +/home/cocci/testing/tools/testing/selftests/bpf/progs/profiler.inc.h:386:19-23: WARNING comparing pointer to 0 +/home/cocci/testing/tools/testing/selftests/bpf/progs/profiler.inc.h:390:19-23: WARNING comparing pointer to 0 +/home/cocci/testing/tools/testing/selftests/bpf/progs/profiler.inc.h:393:20-24: WARNING comparing pointer to 0 +/home/cocci/testing/tools/testing/selftests/bpf/progs/profiler.inc.h:403:20-24: WARNING comparing pointer to 0 +/home/cocci/testing/tools/testing/selftests/bpf/progs/profiler.inc.h:435:20-24: WARNING comparing pointer to 0 Per-file breakdown