Please check for false positives in the output before submitting a patch. When using "patch" mode, carefully review the patch before submitting it. /home/cocci/testing/drivers/scsi/megaraid/megaraid_sas_base.c:3419:8-16: WARNING: please use sysfs_emit or sysfs_emit_at /home/cocci/testing/drivers/scsi/megaraid/megaraid_sas_base.c:3409:8-16: WARNING: please use sysfs_emit or sysfs_emit_at /home/cocci/testing/drivers/scsi/megaraid/megaraid_sas_base.c:3336:8-16: WARNING: please use sysfs_emit or sysfs_emit_at /home/cocci/testing/drivers/scsi/megaraid/megaraid_sas_base.c:3382:8-16: WARNING: please use sysfs_emit or sysfs_emit_at /home/cocci/testing/drivers/scsi/megaraid/megaraid_sas_base.c:3399:8-16: WARNING: please use sysfs_emit or sysfs_emit_at /home/cocci/testing/drivers/scsi/megaraid/megaraid_sas_base.c:3389:8-16: WARNING: please use sysfs_emit or sysfs_emit_at /home/cocci/testing/drivers/scsi/megaraid/megaraid_sas_base.c:3473:8-16: WARNING: please use sysfs_emit or sysfs_emit_at /home/cocci/testing/drivers/scsi/pmcraid.c:3635:8-16: WARNING: please use sysfs_emit or sysfs_emit_at /home/cocci/testing/drivers/scsi/pmcraid.c:3602:8-16: WARNING: please use sysfs_emit or sysfs_emit_at /home/cocci/testing/drivers/scsi/pmcraid.c:3541:8-16: WARNING: please use sysfs_emit or sysfs_emit_at /home/cocci/testing/drivers/scsi/hpsa.c:538:8-16: WARNING: please use sysfs_emit or sysfs_emit_at /home/cocci/testing/drivers/scsi/hpsa.c:898:8-16: WARNING: please use sysfs_emit or sysfs_emit_at /home/cocci/testing/drivers/scsi/hpsa.c:528:8-16: WARNING: please use sysfs_emit or sysfs_emit_at /home/cocci/testing/drivers/scsi/hpsa.c:799:9-17: WARNING: please use sysfs_emit or sysfs_emit_at /home/cocci/testing/drivers/scsi/hpsa.c:561:8-16: WARNING: please use sysfs_emit or sysfs_emit_at /home/cocci/testing/drivers/scsi/hpsa.c:908:8-16: WARNING: please use sysfs_emit or sysfs_emit_at /home/cocci/testing/drivers/scsi/hpsa.c:645:8-16: WARNING: please use sysfs_emit or sysfs_emit_at /home/cocci/testing/drivers/scsi/hpsa.c:549:8-16: WARNING: please use sysfs_emit or sysfs_emit_at /home/cocci/testing/drivers/scsi/hpsa.c:724:8-16: WARNING: please use sysfs_emit or sysfs_emit_at /home/cocci/testing/drivers/scsi/hpsa.c:775:8-16: WARNING: please use sysfs_emit or sysfs_emit_at /home/cocci/testing/drivers/scsi/hpsa.c:746:8-16: WARNING: please use sysfs_emit or sysfs_emit_at warning: line 134: should no_llseek be a metavariable? warning: line 141: should noop_llseek be a metavariable? warning: line 223: should nonseekable_open be a metavariable? warning: line 290: should nonseekable_open be a metavariable? warning: line 338: should nonseekable_open be a metavariable? /home/cocci/testing/drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c:338:1-7: ERROR: missing iounmap; ioremap on line 279 and execution via conditional on line 288 /home/cocci/testing/drivers/scsi/pmcraid.c:2990:33-36: ERROR: invalid reference to the index variable of the iterator on line 2975 /home/cocci/testing/drivers/scsi/pmcraid.c:2996:20-23: ERROR: invalid reference to the index variable of the iterator on line 2975 /home/cocci/testing/drivers/scsi/pmcraid.c:1614:9-12: ERROR: invalid reference to the index variable of the iterator on line 1570 /home/cocci/testing/drivers/scsi/pmcraid.c:5073:11-14: ERROR: invalid reference to the index variable of the iterator on line 5038 /home/cocci/testing/drivers/scsi/ipr.c:1380:22-25: ERROR: invalid reference to the index variable of the iterator on line 1357 /home/cocci/testing/drivers/scsi/ipr.c:7051:13-16: ERROR: invalid reference to the index variable of the iterator on line 7031 /home/cocci/testing/drivers/scsi/ipr.c:7051:46-49: ERROR: invalid reference to the index variable of the iterator on line 7031 /home/cocci/testing/drivers/scsi/ipr.c:7051:71-74: ERROR: invalid reference to the index variable of the iterator on line 7031 /home/cocci/testing/net/ipv4/inet_connection_sock.c:414:1-7: preceding lock on line 376 /home/cocci/testing/net/ipv4/inet_connection_sock.c:598:1-7: preceding lock on line 561 /home/cocci/testing/net/smc/af_smc.c:2554:0-1: preceding lock on line 2489 /home/cocci/testing/drivers/misc/vmw_vmci/vmci_guest.c:801:9-29: WARNING: Threaded IRQ with no primary handler requested without IRQF_ONESHOT (unless it is nested IRQ) /home/cocci/testing/drivers/misc/vmw_vmci/vmci_guest.c:817:10-30: WARNING: Threaded IRQ with no primary handler requested without IRQF_ONESHOT (unless it is nested IRQ) /home/cocci/testing/drivers/misc/vmw_vmci/vmci_guest.c:827:11-31: WARNING: Threaded IRQ with no primary handler requested without IRQF_ONESHOT (unless it is nested IRQ) /home/cocci/testing/drivers/net/wireless/realtek/rtw89/pci.c:304:5-8: Unneeded variable: "cnt". Return "1" on line 365