Please check for false positives in the output before submitting a patch. When using "patch" mode, carefully review the patch before submitting it. /home/cocci/testing/drivers/net/ethernet/broadcom/bnxt/bnxt.c:5480:6-25: WARNING: atomic_dec_and_test variation before object free at line 5487. /home/cocci/testing/drivers/net/ethernet/sun/niu.c:9586:5-24: WARNING: atomic_dec_and_test variation before object free at line 9587. /home/cocci/testing/net/netfilter/ipvs/ip_vs_ctl.c:528:5-24: WARNING: atomic_dec_and_test variation before object free at line 533. /home/cocci/testing/drivers/net/ethernet/jme.c:1269:9-28: WARNING: atomic_dec_and_test variation before object free at line 1293. /home/cocci/testing/drivers/net/ethernet/jme.c:1269:9-28: WARNING: atomic_dec_and_test variation before object free at line 1332. /home/cocci/testing/kernel/fork.c:943:14-33: WARNING: atomic_dec_and_test variation before object free at line 945. /home/cocci/testing/kernel/fork.c:1383:5-24: WARNING: atomic_dec_and_test variation before object free at line 1385. warning: line 134: should no_llseek be a metavariable? warning: line 141: should noop_llseek be a metavariable? warning: line 223: should nonseekable_open be a metavariable? warning: line 290: should nonseekable_open be a metavariable? warning: line 338: should nonseekable_open be a metavariable? /home/cocci/testing/drivers/infiniband/ulp/ipoib/ipoib_main.c:333:2-10: WARNING: NULL check before dev_{put, hold} functions is not needed. /home/cocci/testing/drivers/net/ethernet/intel/i40e/i40e_main.c:15807:2-8: ERROR: missing iounmap; ioremap on line 15654 and execution via conditional on line 15806 /home/cocci/testing/drivers/net/ethernet/fungible/funeth/funeth_main.c:475:14-18: ERROR: reference preceded by free on line 472 /home/cocci/testing/kernel/bpf/devmap.c:767:9-12: ERROR: iterator variable bound on line 766 cannot be NULL /home/cocci/testing/drivers/net/dsa/mv88e6xxx/chip.c:1568:5-7: ERROR: invalid reference to the index variable of the iterator on line 1537 /home/cocci/testing/drivers/net/dsa/mv88e6xxx/chip.c:1568:38-40: ERROR: invalid reference to the index variable of the iterator on line 1537 /home/cocci/testing/drivers/net/dsa/mv88e6xxx/chip.c:1568:5-7: ERROR: invalid reference to the index variable of the iterator on line 1549 /home/cocci/testing/drivers/net/dsa/mv88e6xxx/chip.c:1568:38-40: ERROR: invalid reference to the index variable of the iterator on line 1549 /home/cocci/testing/drivers/net/team/team_core.c:2747:12-16: ERROR: invalid reference to the index variable of the iterator on line 2748 /home/cocci/testing/net/unix/garbage.c:461:17-23: ERROR: invalid reference to the index variable of the iterator on line 493 /home/cocci/testing/drivers/net/ethernet/intel/igb/igb_main.c:7859:3-8: ERROR: invalid reference to the index variable of the iterator on line 7851 /home/cocci/testing/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c:1537:2-12: second lock on line 1537 /home/cocci/testing/drivers/net/ethernet/intel/ice/ice_main.c:9249:2-8: preceding lock on line 9229 /home/cocci/testing/net/unix/af_unix.c:2466:1-7: preceding lock on line 2375 /home/cocci/testing/net/unix/af_unix.c:3237:3-9: preceding lock on line 3233 /home/cocci/testing/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c:4484:1-7: preceding lock on line 4386 /home/cocci/testing/drivers/net/ethernet/nvidia/forcedeth.c:3474:8-10: WARNING: possible condition with no effect (if == else) /home/cocci/testing/drivers/net/ethernet/intel/iavf/iavf_main.c:2239:6-8: WARNING: possible condition with no effect (if == else) /home/cocci/testing/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c:2782:1-7: WARNING: do_div() does a 64-by-32 division, please consider using div64_ul instead. /home/cocci/testing/drivers/atm/fore200e.h:390:11-14: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) /home/cocci/testing/drivers/atm/fore200e.h:368:11-14: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) /home/cocci/testing/drivers/net/ethernet/freescale/gianfar.c:2213:30-31: WARNING: sum of probable bitmasks, consider | /home/cocci/testing/drivers/net/ethernet/freescale/gianfar.c:3266:38-39: WARNING: sum of probable bitmasks, consider | /home/cocci/testing/drivers/net/ethernet/freescale/gianfar.c:1800:25-26: WARNING: sum of probable bitmasks, consider | /home/cocci/testing/net/phonet/pn_netlink.c:280:9-10: Unneeded semicolon