Please check for false positives in the output before submitting a patch. When using "patch" mode, carefully review the patch before submitting it. warning: line 134: should no_llseek be a metavariable? warning: line 141: should noop_llseek be a metavariable? warning: line 223: should nonseekable_open be a metavariable? warning: line 290: should nonseekable_open be a metavariable? warning: line 338: should nonseekable_open be a metavariable? /home/cocci/testing/drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c:122:39-44: ERROR: invalid reference to the index variable of the iterator on line 102 /home/cocci/testing/drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c:122:48-53: ERROR: invalid reference to the index variable of the iterator on line 102 /home/cocci/testing/drivers/net/ethernet/intel/i40e/i40e_ethtool.c:4100:32-37: ERROR: invalid reference to the index variable of the iterator on line 4054 /home/cocci/testing/kernel/trace/trace_output.c:1016:25-29: ERROR: invalid reference to the index variable of the iterator on line 999 /home/cocci/testing/drivers/net/ethernet/intel/ice/ice_main.c:9283:2-8: preceding lock on line 9263 /home/cocci/testing/net/ipv4/inet_connection_sock.c:424:1-7: preceding lock on line 386 /home/cocci/testing/net/ipv4/inet_connection_sock.c:608:1-7: preceding lock on line 571 /home/cocci/testing/drivers/net/ethernet/intel/ice/ice_ethtool.c:3672:1-7: preceding lock on line 3647 /home/cocci/testing/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c:4487:1-7: preceding lock on line 4389 /home/cocci/testing/net/smc/af_smc.c:2562:0-1: preceding lock on line 2489 /home/cocci/testing/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c:46:85-86: WARNING: Use ARRAY_SIZE /home/cocci/testing/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c:69:63-64: WARNING: Use ARRAY_SIZE /home/cocci/testing/drivers/net/ethernet/mscc/ocelot_ptp.c:154:1-7: WARNING: do_div() does a 64-by-32 division, please consider using div64_long instead. /home/cocci/testing/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c:2782:1-7: WARNING: do_div() does a 64-by-32 division, please consider using div64_ul instead. /home/cocci/testing/include/linux/mlx5/mlx5_ifc.h:414:12-28: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) /home/cocci/testing/include/linux/mlx5/mlx5_ifc.h:3584:11-19: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) /home/cocci/testing/include/linux/mlx5/mlx5_ifc.h:4648:12-17: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) /home/cocci/testing/include/linux/mlx5/mlx5_ifc.h:5544:12-15: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) /home/cocci/testing/include/linux/mlx5/mlx5_ifc.h:5548:30-33: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) /home/cocci/testing/include/linux/mlx5/mlx5_ifc.h:6213:12-25: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) /home/cocci/testing/include/linux/mlx5/mlx5_ifc.h:6638:12-29: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) /home/cocci/testing/include/linux/mlx5/mlx5_ifc.h:7251:12-16: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) /home/cocci/testing/include/linux/mlx5/mlx5_ifc.h:7281:12-24: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) /home/cocci/testing/include/linux/mlx5/mlx5_ifc.h:7391:12-20: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) /home/cocci/testing/include/linux/mlx5/mlx5_ifc.h:7461:12-15: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) /home/cocci/testing/include/linux/mlx5/mlx5_ifc.h:7508:12-26: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) /home/cocci/testing/include/linux/mlx5/mlx5_ifc.h:10230:12-35: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) /home/cocci/testing/include/linux/mlx5/mlx5_ifc.h:10294:12-34: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) /home/cocci/testing/include/linux/mlx5/mlx5_ifc.h:10379:12-38: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) /home/cocci/testing/include/linux/mlx5/mlx5_ifc.h:10384:12-27: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) /home/cocci/testing/include/linux/mlx5/mlx5_ifc.h:10479:12-26: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) /home/cocci/testing/include/linux/mlx5/mlx5_ifc.h:10582:12-17: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) /home/cocci/testing/include/linux/mlx5/mlx5_ifc.h:10615:12-21: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) /home/cocci/testing/include/linux/mlx5/mlx5_ifc.h:10661:12-17: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) /home/cocci/testing/include/linux/mlx5/mlx5_ifc.h:12715:43-54: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) /home/cocci/testing/drivers/net/ethernet/sfc/siena/ptp.c:1446:1-4: alloc with no test, possible model on line 1461 /home/cocci/testing/drivers/net/ethernet/sfc/ptp.c:1568:1-4: alloc with no test, possible model on line 1582