Please check for false positives in the output before submitting a patch. When using "patch" mode, carefully review the patch before submitting it. warning: line 134: should no_llseek be a metavariable? warning: line 141: should noop_llseek be a metavariable? warning: line 223: should nonseekable_open be a metavariable? warning: line 290: should nonseekable_open be a metavariable? warning: line 338: should nonseekable_open be a metavariable? /home/cocci/testing/drivers/net/ethernet/intel/i40e/i40e_main.c:15812:2-8: ERROR: missing iounmap; ioremap on line 15659 and execution via conditional on line 15811 /home/cocci/testing/kernel/bpf/btf.c:4806:6-7: ERROR: iterator variable bound on line 4804 cannot be NULL /home/cocci/testing/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c:12994:27-31: ERROR: invalid reference to the index variable of the iterator on line 12983 /home/cocci/testing/drivers/net/ethernet/intel/igb/igb_main.c:7862:3-8: ERROR: invalid reference to the index variable of the iterator on line 7854 /home/cocci/testing/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c:4487:1-7: preceding lock on line 4389 /home/cocci/testing/kernel/bpf/btf.c:8948:1-7: preceding lock on line 8902 /home/cocci/testing/drivers/net/ethernet/intel/ice/ice_main.c:9300:2-8: preceding lock on line 9280 /home/cocci/testing/tools/lib/bpf/libbpf.c:2041:43-48: WARNING: conversion to bool not needed here /home/cocci/testing/drivers/net/ethernet/intel/iavf/iavf_main.c:2239:6-8: WARNING: possible condition with no effect (if == else) /home/cocci/testing/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c:2782:1-7: WARNING: do_div() does a 64-by-32 division, please consider using div64_ul instead. /home/cocci/testing/drivers/net/ethernet/ti/icssg/icssg_switchdev.c:236:5-8: Unneeded variable: "ret". Return "0" on line 252 /home/cocci/testing/drivers/net/ethernet/ti/icssg/icssg_switchdev.c:264:5-8: Unneeded variable: "ret". Return "0" on line 283