Please check for false positives in the output before submitting a patch. When using "patch" mode, carefully review the patch before submitting it. /home/cocci/testing/drivers/net/ethernet/broadcom/bnxt/bnxt.c:5587:6-25: WARNING: atomic_dec_and_test variation before object free at line 5594. warning: line 140: should noop_llseek be a metavariable? warning: line 222: should nonseekable_open be a metavariable? warning: line 289: should nonseekable_open be a metavariable? warning: line 337: should nonseekable_open be a metavariable? /home/cocci/testing/drivers/net/ethernet/broadcom/bnxt/bnxt.c:11242:8-32: opportunity for str_on_off(( fec & BNXT_FEC_AUTONEG )) /home/cocci/testing/drivers/net/phy/realtek.c:438:3-12: opportunity for str_enabled_disabled(val_rxdly) /home/cocci/testing/drivers/net/phy/realtek.c:423:3-12: opportunity for str_enabled_disabled(val_txdly) /home/cocci/testing/drivers/pci/pci.c:2557:27-33: opportunity for str_enabled_disabled(enable) /home/cocci/testing/drivers/net/usb/smsc95xx.c:564:5-13: opportunity for str_enabled_disabled(rx_pause) /home/cocci/testing/drivers/net/usb/smsc95xx.c:565:5-13: opportunity for str_enabled_disabled(tx_pause) /home/cocci/testing/drivers/net/ethernet/microchip/sparx5/sparx5_mactable.c:400:16-26: ERROR: invalid reference to the index variable of the iterator on line 383 /home/cocci/testing/drivers/scsi/storvsc_drv.c:639:42-49: ERROR: invalid reference to the index variable of the iterator on line 628 /home/cocci/testing/net/ipv4/inet_connection_sock.c:424:1-7: preceding lock on line 386 /home/cocci/testing/net/ipv4/inet_connection_sock.c:608:1-7: preceding lock on line 571 /home/cocci/testing/drivers/net/ethernet/microchip/sparx5/sparx5_tc_flower.c:1528:5-8: Unneeded variable: "err". Return "- ENOENT" on line 1543 /home/cocci/testing/drivers/pci/pci.c:6883:6-10: duplicated argument to && or ||