Please check for false positives in the output before submitting a patch. When using "patch" mode, carefully review the patch before submitting it. /home/cocci/testing/drivers/net/ethernet/broadcom/bnxt/bnxt.c:5585:6-25: WARNING: atomic_dec_and_test variation before object free at line 5592. warning: line 140: should noop_llseek be a metavariable? warning: line 222: should nonseekable_open be a metavariable? warning: line 289: should nonseekable_open be a metavariable? warning: line 337: should nonseekable_open be a metavariable? /home/cocci/testing/drivers/net/ethernet/realtek/r8169_main.c:5561:7-23: opportunity for str_enabled_disabled(tp -> dash_enabled) /home/cocci/testing/net/core/sock.c:4156:1-29: opportunity for str_yes_no(proto_memory_pressure ( proto )) /home/cocci/testing/drivers/char/virtio_console.c:1273:5-26: opportunity for str_yes_no(is_console_port ( port )) /home/cocci/testing/drivers/pci/pci.c:2555:27-33: opportunity for str_enabled_disabled(enable) /home/cocci/testing/drivers/net/ethernet/broadcom/bnxt/bnxt.c:11155:8-32: opportunity for str_on_off(( fec & BNXT_FEC_AUTONEG )) /home/cocci/testing/drivers/net/ethernet/broadcom/tg3.c:1892:8-21: opportunity for str_enabled_disabled(tp -> setlpicnt) /home/cocci/testing/drivers/net/ethernet/broadcom/tg3.c:1887:7-55: opportunity for str_on_off(( tp -> link_config . active_flowctrl & FLOW_CTRL_RX )) /home/cocci/testing/drivers/net/ethernet/broadcom/tg3.c:1885:7-55: opportunity for str_on_off(( tp -> link_config . active_flowctrl & FLOW_CTRL_TX )) /home/cocci/testing/drivers/net/ethernet/faraday/ftgmac100.c:1762:5-16: opportunity for str_up_down(nd -> link_up) /home/cocci/testing/drivers/net/phy/realtek.c:438:3-12: opportunity for str_enabled_disabled(val_rxdly) /home/cocci/testing/drivers/net/phy/realtek.c:423:3-12: opportunity for str_enabled_disabled(val_txdly) /home/cocci/testing/drivers/net/ethernet/freescale/fman/fman_port.c:1871:1-7: ERROR: missing put_device; call of_find_device_by_node on line 1772, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/ethernet/freescale/fman/fman_port.c:1879:1-7: ERROR: missing put_device; call of_find_device_by_node on line 1772, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/ethernet/freescale/fman/mac.c:224:2-8: ERROR: missing put_device; call of_find_device_by_node on line 194, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/ethernet/freescale/fman/mac.c:231:2-8: ERROR: missing put_device; call of_find_device_by_node on line 194, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/ethernet/freescale/fman/mac.c:238:2-8: ERROR: missing put_device; call of_find_device_by_node on line 194, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/ethernet/freescale/fman/mac.c:242:2-8: ERROR: missing put_device; call of_find_device_by_node on line 194, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/ethernet/freescale/fman/mac.c:248:2-8: ERROR: missing put_device; call of_find_device_by_node on line 194, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/ethernet/freescale/fman/mac.c:262:2-8: ERROR: missing put_device; call of_find_device_by_node on line 194, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/ethernet/freescale/fman/mac.c:268:2-8: ERROR: missing put_device; call of_find_device_by_node on line 194, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/ethernet/freescale/fman/mac.c:277:3-9: ERROR: missing put_device; call of_find_device_by_node on line 194, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/ethernet/freescale/fman/mac.c:315:2-8: ERROR: missing put_device; call of_find_device_by_node on line 194, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/ethernet/freescale/fman/mac.c:328:1-7: ERROR: missing put_device; call of_find_device_by_node on line 194, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/ethernet/freescale/fman/mac.c:332:1-7: ERROR: missing put_device; call of_find_device_by_node on line 194, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/ethernet/freescale/fman/mac.c:277:3-9: ERROR: missing put_device; call of_find_device_by_node on line 280, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/ethernet/freescale/fman/mac.c:315:2-8: ERROR: missing put_device; call of_find_device_by_node on line 280, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/ethernet/freescale/fman/mac.c:328:1-7: ERROR: missing put_device; call of_find_device_by_node on line 280, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/ethernet/freescale/fman/mac.c:332:1-7: ERROR: missing put_device; call of_find_device_by_node on line 280, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/ethernet/microchip/sparx5/sparx5_mactable.c:398:16-26: ERROR: invalid reference to the index variable of the iterator on line 381 /home/cocci/testing/drivers/net/dsa/mv88e6xxx/chip.c:1592:5-7: ERROR: invalid reference to the index variable of the iterator on line 1561 /home/cocci/testing/drivers/net/dsa/mv88e6xxx/chip.c:1592:38-40: ERROR: invalid reference to the index variable of the iterator on line 1561 /home/cocci/testing/drivers/net/dsa/mv88e6xxx/chip.c:1592:5-7: ERROR: invalid reference to the index variable of the iterator on line 1573 /home/cocci/testing/drivers/net/dsa/mv88e6xxx/chip.c:1592:38-40: ERROR: invalid reference to the index variable of the iterator on line 1573 /home/cocci/testing/net/core/pktgen.c:3240:1-7: preceding lock on line 3233 /home/cocci/testing/drivers/net/ethernet/faraday/ftgmac100.c:1373:0-1: preceding lock on line 1338 /home/cocci/testing/drivers/net/ethernet/faraday/ftgmac100.c:1373:0-1: preceding lock on line 1340 /home/cocci/testing/drivers/net/ethernet/microchip/sparx5/sparx5_tc_flower.c:1526:5-8: Unneeded variable: "err". Return "- ENOENT" on line 1541 /home/cocci/testing/net/ipv4/igmp.c:597:12-21: ERROR: pmc is NULL but dereferenced. /home/cocci/testing/drivers/pci/pci.c:6881:6-10: duplicated argument to && or ||