Please check for false positives in the output before submitting a patch. When using "patch" mode, carefully review the patch before submitting it. /home/cocci/testing/drivers/net/ethernet/broadcom/bnxt/bnxt.c:5587:6-25: WARNING: atomic_dec_and_test variation before object free at line 5594. warning: line 140: should noop_llseek be a metavariable? warning: line 222: should nonseekable_open be a metavariable? warning: line 289: should nonseekable_open be a metavariable? warning: line 337: should nonseekable_open be a metavariable? /home/cocci/testing/drivers/char/virtio_console.c:1273:5-26: opportunity for str_yes_no(is_console_port ( port )) /home/cocci/testing/drivers/net/ethernet/broadcom/bnxt/bnxt.c:11242:8-32: opportunity for str_on_off(( fec & BNXT_FEC_AUTONEG )) /home/cocci/testing/drivers/net/ethernet/faraday/ftgmac100.c:1762:5-16: opportunity for str_up_down(nd -> link_up) /home/cocci/testing/drivers/pci/pci.c:2557:27-33: opportunity for str_enabled_disabled(enable) /home/cocci/testing/drivers/net/ethernet/realtek/r8169_main.c:5605:7-23: opportunity for str_enabled_disabled(tp -> dash_enabled) /home/cocci/testing/drivers/net/phy/realtek.c:438:3-12: opportunity for str_enabled_disabled(val_rxdly) /home/cocci/testing/drivers/net/phy/realtek.c:423:3-12: opportunity for str_enabled_disabled(val_txdly) /home/cocci/testing/drivers/net/ethernet/mellanox/mlx4/main.c:2285:6-35: opportunity for str_enabled_disabled(port_cap . dmfs_optimized_state) /home/cocci/testing/drivers/net/ethernet/mellanox/mlx4/main.c:1071:3-26: opportunity for str_on_off(hca_param -> rss_ip_frags) /home/cocci/testing/drivers/net/ethernet/freescale/fman/fman_port.c:1871:1-7: ERROR: missing put_device; call of_find_device_by_node on line 1772, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/ethernet/freescale/fman/fman_port.c:1879:1-7: ERROR: missing put_device; call of_find_device_by_node on line 1772, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/ethernet/freescale/fman/mac.c:182:2-8: ERROR: missing put_device; call of_find_device_by_node on line 152, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/ethernet/freescale/fman/mac.c:189:2-8: ERROR: missing put_device; call of_find_device_by_node on line 152, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/ethernet/freescale/fman/mac.c:196:2-8: ERROR: missing put_device; call of_find_device_by_node on line 152, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/ethernet/freescale/fman/mac.c:200:2-8: ERROR: missing put_device; call of_find_device_by_node on line 152, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/ethernet/freescale/fman/mac.c:206:2-8: ERROR: missing put_device; call of_find_device_by_node on line 152, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/ethernet/freescale/fman/mac.c:220:2-8: ERROR: missing put_device; call of_find_device_by_node on line 152, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/ethernet/freescale/fman/mac.c:226:2-8: ERROR: missing put_device; call of_find_device_by_node on line 152, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/ethernet/freescale/fman/mac.c:235:3-9: ERROR: missing put_device; call of_find_device_by_node on line 152, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/ethernet/freescale/fman/mac.c:273:2-8: ERROR: missing put_device; call of_find_device_by_node on line 152, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/ethernet/freescale/fman/mac.c:286:1-7: ERROR: missing put_device; call of_find_device_by_node on line 152, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/ethernet/freescale/fman/mac.c:290:1-7: ERROR: missing put_device; call of_find_device_by_node on line 152, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/ethernet/freescale/fman/mac.c:235:3-9: ERROR: missing put_device; call of_find_device_by_node on line 238, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/ethernet/freescale/fman/mac.c:273:2-8: ERROR: missing put_device; call of_find_device_by_node on line 238, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/ethernet/freescale/fman/mac.c:286:1-7: ERROR: missing put_device; call of_find_device_by_node on line 238, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/ethernet/freescale/fman/mac.c:290:1-7: ERROR: missing put_device; call of_find_device_by_node on line 238, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/ethernet/faraday/ftgmac100.c:1373:0-1: preceding lock on line 1338 /home/cocci/testing/drivers/net/ethernet/faraday/ftgmac100.c:1373:0-1: preceding lock on line 1340 /home/cocci/testing/net/core/pktgen.c:3240:1-7: preceding lock on line 3233 /home/cocci/testing/net/ipv4/igmp.c:597:12-21: ERROR: pmc is NULL but dereferenced. /home/cocci/testing/drivers/pci/pci.c:6883:6-10: duplicated argument to && or ||