Please check for false positives in the output before submitting a patch. When using "patch" mode, carefully review the patch before submitting it. warning: line 140: should noop_llseek be a metavariable? warning: line 222: should nonseekable_open be a metavariable? warning: line 289: should nonseekable_open be a metavariable? warning: line 337: should nonseekable_open be a metavariable? /home/cocci/testing/drivers/net/ethernet/realtek/r8169_main.c:5605:7-23: opportunity for str_enabled_disabled(tp -> dash_enabled) /home/cocci/testing/drivers/net/ethernet/mellanox/mlx4/main.c:2279:6-35: opportunity for str_enabled_disabled(port_cap . dmfs_optimized_state) /home/cocci/testing/drivers/net/ethernet/mellanox/mlx4/main.c:1070:3-26: opportunity for str_on_off(hca_param -> rss_ip_frags) /home/cocci/testing/drivers/net/ethernet/intel/igb/igb_main.c:1829:5-21: opportunity for str_enabled_disabled(ring -> cbs_enable) /home/cocci/testing/drivers/net/ethernet/intel/igb/igb_main.c:1830:5-28: opportunity for str_enabled_disabled(ring -> launchtime_enable) /home/cocci/testing/drivers/net/ethernet/intel/igb/igb_main.c:1954:34-61: opportunity for str_enabled_disabled(( is_fqtss_enabled ( adapter ) )) /home/cocci/testing/drivers/net/phy/phylink.c:1842:49-51: opportunity for str_up_down(up) /home/cocci/testing/drivers/net/phy/phylink.c:2163:39-41: opportunity for str_up_down(up) /home/cocci/testing/drivers/net/ethernet/faraday/ftgmac100.c:1762:5-16: opportunity for str_up_down(nd -> link_up) /home/cocci/testing/drivers/net/ethernet/intel/i40e/i40e_main.c:2848:5-16: opportunity for str_on_off(cur_promisc) /home/cocci/testing/drivers/net/ethernet/intel/i40e/i40e_main.c:11148:4-19: opportunity for str_on_off(pf -> cur_promisc) /home/cocci/testing/drivers/net/phy/realtek.c:438:3-12: opportunity for str_enabled_disabled(val_rxdly) /home/cocci/testing/drivers/net/phy/realtek.c:423:3-12: opportunity for str_enabled_disabled(val_txdly) /home/cocci/testing/drivers/net/ethernet/intel/ice/ice_sriov.c:1880:3-50: opportunity for str_on_off(test_bit ( ICE_FLAG_MDD_AUTO_RESET_VF , pf -> flags )) /home/cocci/testing/drivers/net/ethernet/intel/ice/ice_sriov.c:1898:3-50: opportunity for str_on_off(test_bit ( ICE_FLAG_MDD_AUTO_RESET_VF , pf -> flags )) /home/cocci/testing/drivers/net/ethernet/intel/i40e/i40e_main.c:15829:2-8: ERROR: missing iounmap; ioremap on line 15676 and execution via conditional on line 15828 /home/cocci/testing/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c:551:29-44: ERROR: reference preceded by free on line 550 /home/cocci/testing/drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c:122:39-44: ERROR: invalid reference to the index variable of the iterator on line 102 /home/cocci/testing/drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c:122:48-53: ERROR: invalid reference to the index variable of the iterator on line 102 /home/cocci/testing/drivers/net/dsa/mv88e6xxx/chip.c:1592:5-7: ERROR: invalid reference to the index variable of the iterator on line 1561 /home/cocci/testing/drivers/net/dsa/mv88e6xxx/chip.c:1592:38-40: ERROR: invalid reference to the index variable of the iterator on line 1561 /home/cocci/testing/drivers/net/dsa/mv88e6xxx/chip.c:1592:5-7: ERROR: invalid reference to the index variable of the iterator on line 1573 /home/cocci/testing/drivers/net/dsa/mv88e6xxx/chip.c:1592:38-40: ERROR: invalid reference to the index variable of the iterator on line 1573 /home/cocci/testing/drivers/net/ethernet/intel/igb/igb_main.c:7876:3-8: ERROR: invalid reference to the index variable of the iterator on line 7868 /home/cocci/testing/drivers/net/ethernet/intel/ice/ice_vf_lib.c:972:1-7: preceding lock on line 865 /home/cocci/testing/drivers/net/ethernet/faraday/ftgmac100.c:1373:0-1: preceding lock on line 1338 /home/cocci/testing/drivers/net/ethernet/faraday/ftgmac100.c:1373:0-1: preceding lock on line 1340 /home/cocci/testing/drivers/net/ethernet/intel/ice/ice_ethtool.c:4019:1-7: preceding lock on line 3994 /home/cocci/testing/drivers/net/ethernet/intel/ice/ice_main.c:9317:2-8: preceding lock on line 9297 /home/cocci/testing/net/ipv4/inet_connection_sock.c:424:1-7: preceding lock on line 386 /home/cocci/testing/net/ipv4/inet_connection_sock.c:608:1-7: preceding lock on line 571