Please check for false positives in the output before submitting a patch.
When using "patch" mode, carefully review the patch before submitting it.

warning: line 140: should noop_llseek be a metavariable?
warning: line 222: should nonseekable_open be a metavariable?
warning: line 289: should nonseekable_open be a metavariable?
warning: line 337: should nonseekable_open be a metavariable?
/home/cocci/testing/drivers/net/ethernet/broadcom/tg3.c:1892:8-21: opportunity for str_enabled_disabled(tp -> setlpicnt)
/home/cocci/testing/drivers/net/ethernet/broadcom/tg3.c:1887:7-55: opportunity for str_on_off(( tp -> link_config . active_flowctrl & FLOW_CTRL_RX ))
/home/cocci/testing/drivers/net/ethernet/broadcom/tg3.c:1885:7-55: opportunity for str_on_off(( tp -> link_config . active_flowctrl & FLOW_CTRL_TX ))
/home/cocci/testing/drivers/net/ethernet/mellanox/mlx4/main.c:2285:6-35: opportunity for str_enabled_disabled(port_cap . dmfs_optimized_state)
/home/cocci/testing/drivers/net/ethernet/mellanox/mlx4/main.c:1071:3-26: opportunity for str_on_off(hca_param -> rss_ip_frags)
/home/cocci/testing/drivers/net/ethernet/realtek/r8169_main.c:5607:7-23: opportunity for str_enabled_disabled(tp -> dash_enabled)
/home/cocci/testing/drivers/net/phy/phylink.c:1834:49-51: opportunity for str_up_down(up)
/home/cocci/testing/drivers/net/phy/phylink.c:2162:39-41: opportunity for str_up_down(up)
/home/cocci/testing/drivers/net/phy/realtek.c:442:3-12: opportunity for str_enabled_disabled(val_rxdly)
/home/cocci/testing/drivers/net/phy/realtek.c:427:3-12: opportunity for str_enabled_disabled(val_txdly)
/home/cocci/testing/drivers/net/dsa/mv88e6xxx/chip.c:1592:5-7: ERROR: invalid reference to the index variable of the iterator on line 1561
/home/cocci/testing/drivers/net/dsa/mv88e6xxx/chip.c:1592:38-40: ERROR: invalid reference to the index variable of the iterator on line 1561
/home/cocci/testing/drivers/net/dsa/mv88e6xxx/chip.c:1592:5-7: ERROR: invalid reference to the index variable of the iterator on line 1573
/home/cocci/testing/drivers/net/dsa/mv88e6xxx/chip.c:1592:38-40: ERROR: invalid reference to the index variable of the iterator on line 1573
/home/cocci/testing/net/ipv4/inet_connection_sock.c:424:1-7: preceding lock on line 386
/home/cocci/testing/net/ipv4/inet_connection_sock.c:608:1-7: preceding lock on line 571