Please check for false positives in the output before submitting a patch. When using "patch" mode, carefully review the patch before submitting it. warning: line 140: should noop_llseek be a metavariable? warning: line 222: should nonseekable_open be a metavariable? warning: line 289: should nonseekable_open be a metavariable? warning: line 337: should nonseekable_open be a metavariable? /home/cocci/testing/drivers/net/phy/realtek.c:438:3-12: opportunity for str_enabled_disabled(val_rxdly) /home/cocci/testing/drivers/net/phy/realtek.c:423:3-12: opportunity for str_enabled_disabled(val_txdly) /home/cocci/testing/drivers/net/ethernet/broadcom/tg3.c:1892:8-21: opportunity for str_enabled_disabled(tp -> setlpicnt) /home/cocci/testing/drivers/net/ethernet/broadcom/tg3.c:1887:7-55: opportunity for str_on_off(( tp -> link_config . active_flowctrl & FLOW_CTRL_RX )) /home/cocci/testing/drivers/net/ethernet/broadcom/tg3.c:1885:7-55: opportunity for str_on_off(( tp -> link_config . active_flowctrl & FLOW_CTRL_TX )) /home/cocci/testing/drivers/net/phy/phylink.c:1842:49-51: opportunity for str_up_down(up) /home/cocci/testing/drivers/net/phy/phylink.c:2163:39-41: opportunity for str_up_down(up) /home/cocci/testing/drivers/net/ethernet/realtek/r8169_main.c:5607:7-23: opportunity for str_enabled_disabled(tp -> dash_enabled) /home/cocci/testing/net/core/sock.c:4154:1-29: opportunity for str_yes_no(proto_memory_pressure ( proto )) /home/cocci/testing/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c:6194:9-13: ERROR: invalid reference to the index variable of the iterator on line 6186 /home/cocci/testing/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c:4487:1-7: preceding lock on line 4389 /home/cocci/testing/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c:6398:1-7: preceding lock on line 6359 /home/cocci/testing/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c:6535:1-7: preceding lock on line 6428 /home/cocci/testing/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c:2782:1-7: WARNING: do_div() does a 64-by-32 division, please consider using div64_ul instead.