Please check for false positives in the output before submitting a patch.
When using "patch" mode, carefully review the patch before submitting it.

warning: line 140: should noop_llseek be a metavariable?
warning: line 222: should nonseekable_open be a metavariable?
warning: line 289: should nonseekable_open be a metavariable?
warning: line 337: should nonseekable_open be a metavariable?
/home/cocci/testing/net/core/sock.c:4151:1-29: opportunity for str_yes_no(proto_memory_pressure ( proto ))
/home/cocci/testing/drivers/net/ethernet/broadcom/tg3.c:1892:8-21: opportunity for str_enabled_disabled(tp -> setlpicnt)
/home/cocci/testing/drivers/net/ethernet/broadcom/tg3.c:1887:7-55: opportunity for str_on_off(( tp -> link_config . active_flowctrl & FLOW_CTRL_RX ))
/home/cocci/testing/drivers/net/ethernet/broadcom/tg3.c:1885:7-55: opportunity for str_on_off(( tp -> link_config . active_flowctrl & FLOW_CTRL_TX ))
/home/cocci/testing/drivers/net/ethernet/faraday/ftgmac100.c:1762:5-16: opportunity for str_up_down(nd -> link_up)
/home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c:664:28-19: opportunity for str_on_off(readl_relaxed ( ring -> tqp -> io_base + HNS3_RING_EN_REG ))
/home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c:767:28-19: opportunity for str_on_off(readl_relaxed ( ring -> tqp -> io_base + HNS3_RING_EN_REG ))
/home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c:668:29-23: opportunity for str_on_off(readl_relaxed ( ring -> tqp -> io_base + HNS3_RING_RX_EN_REG ))
/home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c:771:29-23: opportunity for str_on_off(readl_relaxed ( ring -> tqp -> io_base + HNS3_RING_TX_EN_REG ))
/home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c:1221:5-14: opportunity for str_on_off(old_state)
/home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c:1221:31-38: opportunity for str_on_off(tx_push)
/home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c:8014:3-5: opportunity for str_enable_disable(en)
/home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c:11214:3-39: opportunity for str_enable_disable(handle -> kinfo . tc_info . dcb_ets_active)
/home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c:11216:3-38: opportunity for str_enable_disable(handle -> kinfo . tc_info . mqprio_active)
/home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c:11990:7-13: opportunity for str_on_off(enable)
/home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c:11998:7-13: opportunity for str_on_off(enable)
/home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_ptp.c:229:3-5: opportunity for str_enable_disable(en)
/home/cocci/testing/drivers/net/phy/realtek.c:441:3-12: opportunity for str_enabled_disabled(val_rxdly)
/home/cocci/testing/drivers/net/phy/realtek.c:426:3-12: opportunity for str_enabled_disabled(val_txdly)
/home/cocci/testing/drivers/net/phy/phylink.c:1835:49-51: opportunity for str_up_down(up)
/home/cocci/testing/drivers/net/phy/phylink.c:2156:39-41: opportunity for str_up_down(up)
/home/cocci/testing/drivers/net/ethernet/intel/ice/ice_switch.c:2100:19-37: opportunity for str_true_false(params -> mask_valid)
/home/cocci/testing/drivers/net/ethernet/realtek/r8169_main.c:5651:7-23: opportunity for str_enabled_disabled(tp -> dash_enabled)
/home/cocci/testing/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c:6194:9-13: ERROR: invalid reference to the index variable of the iterator on line 6186
/home/cocci/testing/net/ethtool/ioctl.c:1607:1-7: preceding lock on line 1462
/home/cocci/testing/drivers/net/ethernet/faraday/ftgmac100.c:1373:0-1: preceding lock on line 1338
/home/cocci/testing/drivers/net/ethernet/faraday/ftgmac100.c:1373:0-1: preceding lock on line 1340
/home/cocci/testing/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c:6398:1-7: preceding lock on line 6359
/home/cocci/testing/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c:6535:1-7: preceding lock on line 6428
/home/cocci/testing/drivers/net/ethernet/freescale/gianfar.c:2216:30-31: WARNING: sum of probable bitmasks, consider |
/home/cocci/testing/drivers/net/ethernet/freescale/gianfar.c:3269:38-39: WARNING: sum of probable bitmasks, consider |
/home/cocci/testing/drivers/net/ethernet/freescale/gianfar.c:1802:25-26: WARNING: sum of probable bitmasks, consider |