New output added --- /home/cocci/outputs/results/815302/old-filtered 2024-10-14 09:41:06.985836199 -0700 +++ /home/cocci/outputs/results/815302/new-filtered 2024-10-14 09:41:07.005836317 -0700 @@ -11,4 +11,2 @@ -/home/cocci/testing/drivers/net/phy/phylink.c:1842:49-51: opportunity for str_up_down(up) -/home/cocci/testing/drivers/net/phy/phylink.c:2163:39-41: opportunity for str_up_down(up) -/home/cocci/testing/drivers/net/ethernet/realtek/r8169_main.c:5613:7-23: opportunity for str_enabled_disabled(tp -> dash_enabled) -/home/cocci/testing/drivers/net/ethernet/intel/ice/ice_switch.c:2100:19-37: opportunity for str_true_false(params -> mask_valid) +/home/cocci/testing/drivers/net/ethernet/realtek/r8169_main.c:5651:7-23: opportunity for str_enabled_disabled(tp -> dash_enabled) +/home/cocci/testing/net/core/sock.c:4151:1-29: opportunity for str_yes_no(proto_memory_pressure ( proto )) @@ -21 +19,2 @@ -/home/cocci/testing/net/core/sock.c:4154:1-29: opportunity for str_yes_no(proto_memory_pressure ( proto )) +/home/cocci/testing/drivers/net/phy/realtek.c:441:3-12: opportunity for str_enabled_disabled(val_rxdly) +/home/cocci/testing/drivers/net/phy/realtek.c:426:3-12: opportunity for str_enabled_disabled(val_txdly) @@ -22,0 +22 @@ +/home/cocci/testing/drivers/net/ethernet/intel/ice/ice_switch.c:2100:19-37: opportunity for str_true_false(params -> mask_valid) @@ -27,2 +27,2 @@ -/home/cocci/testing/drivers/net/phy/realtek.c:438:3-12: opportunity for str_enabled_disabled(val_rxdly) -/home/cocci/testing/drivers/net/phy/realtek.c:423:3-12: opportunity for str_enabled_disabled(val_txdly) +/home/cocci/testing/drivers/net/phy/phylink.c:1835:49-51: opportunity for str_up_down(up) +/home/cocci/testing/drivers/net/phy/phylink.c:2156:39-41: opportunity for str_up_down(up) @@ -31,6 +31,6 @@ -/home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c:7987:3-5: opportunity for str_enable_disable(en) -/home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c:11187:3-39: opportunity for str_enable_disable(handle -> kinfo . tc_info . dcb_ets_active) -/home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c:11189:3-38: opportunity for str_enable_disable(handle -> kinfo . tc_info . mqprio_active) -/home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c:11962:7-13: opportunity for str_on_off(enable) -/home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c:11970:7-13: opportunity for str_on_off(enable) -/home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_ptp.c:226:3-5: opportunity for str_enable_disable(en) +/home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c:8014:3-5: opportunity for str_enable_disable(en) +/home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c:11214:3-39: opportunity for str_enable_disable(handle -> kinfo . tc_info . dcb_ets_active) +/home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c:11216:3-38: opportunity for str_enable_disable(handle -> kinfo . tc_info . mqprio_active) +/home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c:11990:7-13: opportunity for str_on_off(enable) +/home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c:11998:7-13: opportunity for str_on_off(enable) +/home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_ptp.c:229:3-5: opportunity for str_enable_disable(en) @@ -43,3 +43 @@ -/home/cocci/testing/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c:6398:1-7: preceding lock on line 6359 -/home/cocci/testing/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c:6535:1-7: preceding lock on line 6428 -/home/cocci/testing/net/ethtool/ioctl.c:1600:1-7: preceding lock on line 1462 +/home/cocci/testing/net/ethtool/ioctl.c:1607:1-7: preceding lock on line 1462 @@ -48,2 +46,4 @@ -/home/cocci/testing/drivers/net/ethernet/freescale/gianfar.c:2215:30-31: WARNING: sum of probable bitmasks, consider | -/home/cocci/testing/drivers/net/ethernet/freescale/gianfar.c:3268:38-39: WARNING: sum of probable bitmasks, consider | +/home/cocci/testing/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c:6398:1-7: preceding lock on line 6359 +/home/cocci/testing/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c:6535:1-7: preceding lock on line 6428 +/home/cocci/testing/drivers/net/ethernet/freescale/gianfar.c:2216:30-31: WARNING: sum of probable bitmasks, consider | +/home/cocci/testing/drivers/net/ethernet/freescale/gianfar.c:3269:38-39: WARNING: sum of probable bitmasks, consider | @@ -50,0 +51 @@ +/home/cocci/testing/drivers/gpio/gpio-merrifield.c:97:5-11: inconsistent IS_ERR and PTR_ERR on line 98. Per-file breakdown --- /tmp/tmp.cJ1AxZAJtZ 2024-10-14 09:41:07.025836431 -0700 +++ /tmp/tmp.sdpgA7tkiv 2024-10-14 09:41:07.025836431 -0700 @@ -1,0 +2 @@ + 1 /drivers/gpio/gpio-merrifield.c