Please check for false positives in the output before submitting a patch. When using "patch" mode, carefully review the patch before submitting it. warning: line 140: should noop_llseek be a metavariable? warning: line 222: should nonseekable_open be a metavariable? warning: line 289: should nonseekable_open be a metavariable? warning: line 337: should nonseekable_open be a metavariable? /home/cocci/testing/drivers/net/ethernet/broadcom/tg3.c:1892:8-21: opportunity for str_enabled_disabled(tp -> setlpicnt) /home/cocci/testing/drivers/net/ethernet/broadcom/tg3.c:1887:7-55: opportunity for str_on_off(( tp -> link_config . active_flowctrl & FLOW_CTRL_RX )) /home/cocci/testing/drivers/net/ethernet/broadcom/tg3.c:1885:7-55: opportunity for str_on_off(( tp -> link_config . active_flowctrl & FLOW_CTRL_TX )) /home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c:664:28-19: opportunity for str_on_off(readl_relaxed ( ring -> tqp -> io_base + HNS3_RING_EN_REG )) /home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c:767:28-19: opportunity for str_on_off(readl_relaxed ( ring -> tqp -> io_base + HNS3_RING_EN_REG )) /home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c:668:29-23: opportunity for str_on_off(readl_relaxed ( ring -> tqp -> io_base + HNS3_RING_RX_EN_REG )) /home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c:771:29-23: opportunity for str_on_off(readl_relaxed ( ring -> tqp -> io_base + HNS3_RING_TX_EN_REG )) /home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c:1221:5-14: opportunity for str_on_off(old_state) /home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c:1221:31-38: opportunity for str_on_off(tx_push) /home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c:7987:3-5: opportunity for str_enable_disable(en) /home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c:11187:3-39: opportunity for str_enable_disable(handle -> kinfo . tc_info . dcb_ets_active) /home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c:11189:3-38: opportunity for str_enable_disable(handle -> kinfo . tc_info . mqprio_active) /home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c:11962:7-13: opportunity for str_on_off(enable) /home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c:11970:7-13: opportunity for str_on_off(enable) /home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_ptp.c:226:3-5: opportunity for str_enable_disable(en) /home/cocci/testing/drivers/net/ethernet/intel/igb/igb_main.c:1829:5-21: opportunity for str_enabled_disabled(ring -> cbs_enable) /home/cocci/testing/drivers/net/ethernet/intel/igb/igb_main.c:1830:5-28: opportunity for str_enabled_disabled(ring -> launchtime_enable) /home/cocci/testing/drivers/net/ethernet/intel/igb/igb_main.c:1954:34-61: opportunity for str_enabled_disabled(( is_fqtss_enabled ( adapter ) )) /home/cocci/testing/drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c:1171:6-18: opportunity for str_enabled_disabled(qopt -> enable) /home/cocci/testing/net/core/sock.c:4151:1-29: opportunity for str_yes_no(proto_memory_pressure ( proto )) /home/cocci/testing/drivers/net/phy/realtek.c:438:3-12: opportunity for str_enabled_disabled(val_rxdly) /home/cocci/testing/drivers/net/phy/realtek.c:423:3-12: opportunity for str_enabled_disabled(val_txdly) /home/cocci/testing/drivers/net/ethernet/freescale/fman/mac.c:182:2-8: ERROR: missing put_device; call of_find_device_by_node on line 152, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/ethernet/freescale/fman/mac.c:189:2-8: ERROR: missing put_device; call of_find_device_by_node on line 152, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/ethernet/freescale/fman/mac.c:196:2-8: ERROR: missing put_device; call of_find_device_by_node on line 152, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/ethernet/freescale/fman/mac.c:200:2-8: ERROR: missing put_device; call of_find_device_by_node on line 152, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/ethernet/freescale/fman/mac.c:206:2-8: ERROR: missing put_device; call of_find_device_by_node on line 152, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/ethernet/freescale/fman/mac.c:220:2-8: ERROR: missing put_device; call of_find_device_by_node on line 152, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/ethernet/freescale/fman/mac.c:226:2-8: ERROR: missing put_device; call of_find_device_by_node on line 152, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/ethernet/freescale/fman/mac.c:235:3-9: ERROR: missing put_device; call of_find_device_by_node on line 152, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/ethernet/freescale/fman/mac.c:273:2-8: ERROR: missing put_device; call of_find_device_by_node on line 152, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/ethernet/freescale/fman/mac.c:286:1-7: ERROR: missing put_device; call of_find_device_by_node on line 152, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/ethernet/freescale/fman/mac.c:290:1-7: ERROR: missing put_device; call of_find_device_by_node on line 152, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/ethernet/freescale/fman/mac.c:235:3-9: ERROR: missing put_device; call of_find_device_by_node on line 238, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/ethernet/freescale/fman/mac.c:273:2-8: ERROR: missing put_device; call of_find_device_by_node on line 238, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/ethernet/freescale/fman/mac.c:286:1-7: ERROR: missing put_device; call of_find_device_by_node on line 238, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/ethernet/freescale/fman/mac.c:290:1-7: ERROR: missing put_device; call of_find_device_by_node on line 238, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/dsa/mv88e6xxx/chip.c:1592:5-7: ERROR: invalid reference to the index variable of the iterator on line 1561 /home/cocci/testing/drivers/net/dsa/mv88e6xxx/chip.c:1592:38-40: ERROR: invalid reference to the index variable of the iterator on line 1561 /home/cocci/testing/drivers/net/dsa/mv88e6xxx/chip.c:1592:5-7: ERROR: invalid reference to the index variable of the iterator on line 1573 /home/cocci/testing/drivers/net/dsa/mv88e6xxx/chip.c:1592:38-40: ERROR: invalid reference to the index variable of the iterator on line 1573 /home/cocci/testing/drivers/net/ethernet/intel/igb/igb_main.c:7876:3-8: ERROR: invalid reference to the index variable of the iterator on line 7868 /home/cocci/testing/net/sched/sch_cbs.c:356:25-26: ERROR: invalid reference to the index variable of the iterator on line 346 /home/cocci/testing/net/ipv4/inet_connection_sock.c:424:1-7: preceding lock on line 386 /home/cocci/testing/net/ipv4/inet_connection_sock.c:608:1-7: preceding lock on line 571 /home/cocci/testing/net/ethtool/ioctl.c:1600:1-7: preceding lock on line 1462