Please check for false positives in the output before submitting a patch. When using "patch" mode, carefully review the patch before submitting it. warning: line 140: should noop_llseek be a metavariable? warning: line 222: should nonseekable_open be a metavariable? warning: line 289: should nonseekable_open be a metavariable? warning: line 337: should nonseekable_open be a metavariable? /home/cocci/testing/drivers/net/dsa/mv88e6xxx/port.c:179:2-38: opportunity for str_up_down(reg & MV88E6XXX_PORT_MAC_CTL_LINK_UP) /home/cocci/testing/drivers/net/dsa/mv88e6xxx/port.c:113:2-48: opportunity for str_yes_no(reg & MV88E6XXX_PORT_MAC_CTL_RGMII_DELAY_RXCLK) /home/cocci/testing/drivers/net/dsa/mv88e6xxx/port.c:114:2-48: opportunity for str_yes_no(reg & MV88E6XXX_PORT_MAC_CTL_RGMII_DELAY_TXCLK) /home/cocci/testing/drivers/net/ethernet/broadcom/tg3.c:1892:8-21: opportunity for str_enabled_disabled(tp -> setlpicnt) /home/cocci/testing/drivers/net/ethernet/broadcom/tg3.c:1887:7-55: opportunity for str_on_off(( tp -> link_config . active_flowctrl & FLOW_CTRL_RX )) /home/cocci/testing/drivers/net/ethernet/broadcom/tg3.c:1885:7-55: opportunity for str_on_off(( tp -> link_config . active_flowctrl & FLOW_CTRL_TX )) /home/cocci/testing/drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c:1171:6-18: opportunity for str_enabled_disabled(qopt -> enable) /home/cocci/testing/drivers/net/phy/realtek.c:438:3-12: opportunity for str_enabled_disabled(val_rxdly) /home/cocci/testing/drivers/net/phy/realtek.c:423:3-12: opportunity for str_enabled_disabled(val_txdly) /home/cocci/testing/drivers/net/ethernet/freescale/fman/mac.c:182:2-8: ERROR: missing put_device; call of_find_device_by_node on line 152, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/ethernet/freescale/fman/mac.c:189:2-8: ERROR: missing put_device; call of_find_device_by_node on line 152, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/ethernet/freescale/fman/mac.c:196:2-8: ERROR: missing put_device; call of_find_device_by_node on line 152, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/ethernet/freescale/fman/mac.c:200:2-8: ERROR: missing put_device; call of_find_device_by_node on line 152, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/ethernet/freescale/fman/mac.c:206:2-8: ERROR: missing put_device; call of_find_device_by_node on line 152, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/ethernet/freescale/fman/mac.c:220:2-8: ERROR: missing put_device; call of_find_device_by_node on line 152, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/ethernet/freescale/fman/mac.c:226:2-8: ERROR: missing put_device; call of_find_device_by_node on line 152, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/ethernet/freescale/fman/mac.c:235:3-9: ERROR: missing put_device; call of_find_device_by_node on line 152, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/ethernet/freescale/fman/mac.c:273:2-8: ERROR: missing put_device; call of_find_device_by_node on line 152, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/ethernet/freescale/fman/mac.c:286:1-7: ERROR: missing put_device; call of_find_device_by_node on line 152, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/ethernet/freescale/fman/mac.c:290:1-7: ERROR: missing put_device; call of_find_device_by_node on line 152, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/ethernet/freescale/fman/mac.c:235:3-9: ERROR: missing put_device; call of_find_device_by_node on line 238, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/ethernet/freescale/fman/mac.c:273:2-8: ERROR: missing put_device; call of_find_device_by_node on line 238, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/ethernet/freescale/fman/mac.c:286:1-7: ERROR: missing put_device; call of_find_device_by_node on line 238, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/ethernet/freescale/fman/mac.c:290:1-7: ERROR: missing put_device; call of_find_device_by_node on line 238, but without a corresponding object release within this function. /home/cocci/testing/net/ethtool/ioctl.c:1600:1-7: preceding lock on line 1462