Please check for false positives in the output before submitting a patch.
When using "patch" mode, carefully review the patch before submitting it.

warning: line 140: should noop_llseek be a metavariable?
warning: line 222: should nonseekable_open be a metavariable?
warning: line 289: should nonseekable_open be a metavariable?
warning: line 337: should nonseekable_open be a metavariable?
/home/cocci/testing/drivers/net/dsa/mv88e6xxx/port.c:179:2-38: opportunity for str_up_down(reg & MV88E6XXX_PORT_MAC_CTL_LINK_UP)
/home/cocci/testing/drivers/net/dsa/mv88e6xxx/port.c:113:2-48: opportunity for str_yes_no(reg & MV88E6XXX_PORT_MAC_CTL_RGMII_DELAY_RXCLK)
/home/cocci/testing/drivers/net/dsa/mv88e6xxx/port.c:114:2-48: opportunity for str_yes_no(reg & MV88E6XXX_PORT_MAC_CTL_RGMII_DELAY_TXCLK)
/home/cocci/testing/drivers/net/phy/realtek.c:439:3-12: opportunity for str_enabled_disabled(val_rxdly)
/home/cocci/testing/drivers/net/phy/realtek.c:424:3-12: opportunity for str_enabled_disabled(val_txdly)
/home/cocci/testing/drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c:1171:6-18: opportunity for str_enabled_disabled(qopt -> enable)
/home/cocci/testing/net/ethtool/ioctl.c:1607:1-7: preceding lock on line 1462
/home/cocci/testing/include/net/libeth/xdp.h:660:2-3: Unneeded semicolon
/home/cocci/testing/include/net/libeth/xdp.h:957:2-3: Unneeded semicolon
/home/cocci/testing/include/net/libeth/xsk.h:93:2-3: Unneeded semicolon