Please check for false positives in the output before submitting a patch. When using "patch" mode, carefully review the patch before submitting it. /home/cocci/testing/drivers/net/ethernet/broadcom/bnxt/bnxt.c:5585:6-25: WARNING: atomic_dec_and_test variation before object free at line 5592. warning: line 140: should noop_llseek be a metavariable? warning: line 222: should nonseekable_open be a metavariable? warning: line 289: should nonseekable_open be a metavariable? warning: line 337: should nonseekable_open be a metavariable? /home/cocci/testing/drivers/net/phy/phylink.c:1835:49-51: opportunity for str_up_down(up) /home/cocci/testing/drivers/net/phy/phylink.c:2156:39-41: opportunity for str_up_down(up) /home/cocci/testing/drivers/block/mtip32xx/mtip32xx.c:609:5-40: opportunity for str_write_read(fis -> command == ATA_CMD_FPDMA_WRITE) /home/cocci/testing/drivers/net/ethernet/marvell/octeontx2/af/rvu_devlink.c:1254:3-10: opportunity for str_enabled_disabled(enabled) /home/cocci/testing/drivers/net/dsa/mv88e6xxx/port.c:179:2-38: opportunity for str_up_down(reg & MV88E6XXX_PORT_MAC_CTL_LINK_UP) /home/cocci/testing/drivers/net/dsa/mv88e6xxx/port.c:113:2-48: opportunity for str_yes_no(reg & MV88E6XXX_PORT_MAC_CTL_RGMII_DELAY_RXCLK) /home/cocci/testing/drivers/net/dsa/mv88e6xxx/port.c:114:2-48: opportunity for str_yes_no(reg & MV88E6XXX_PORT_MAC_CTL_RGMII_DELAY_TXCLK) /home/cocci/testing/drivers/net/ethernet/broadcom/bnxt/bnxt.c:11156:8-32: opportunity for str_on_off(( fec & BNXT_FEC_AUTONEG )) /home/cocci/testing/drivers/net/ethernet/broadcom/tg3.c:1892:8-21: opportunity for str_enabled_disabled(tp -> setlpicnt) /home/cocci/testing/drivers/net/ethernet/broadcom/tg3.c:1887:7-55: opportunity for str_on_off(( tp -> link_config . active_flowctrl & FLOW_CTRL_RX )) /home/cocci/testing/drivers/net/ethernet/broadcom/tg3.c:1885:7-55: opportunity for str_on_off(( tp -> link_config . active_flowctrl & FLOW_CTRL_TX )) /home/cocci/testing/drivers/net/ethernet/realtek/r8169_main.c:5695:7-23: opportunity for str_enabled_disabled(tp -> dash_enabled) /home/cocci/testing/drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c:1171:6-18: opportunity for str_enabled_disabled(qopt -> enable) /home/cocci/testing/net/core/sock.c:4148:1-29: opportunity for str_yes_no(proto_memory_pressure ( proto )) /home/cocci/testing/drivers/net/ethernet/freescale/enetc/enetc_pf.c:1206:1-7: ERROR: missing put_device; call of_find_device_by_node on line 1200, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/ethernet/freescale/fman/mac.c:182:2-8: ERROR: missing put_device; call of_find_device_by_node on line 152, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/ethernet/freescale/fman/mac.c:189:2-8: ERROR: missing put_device; call of_find_device_by_node on line 152, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/ethernet/freescale/fman/mac.c:196:2-8: ERROR: missing put_device; call of_find_device_by_node on line 152, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/ethernet/freescale/fman/mac.c:200:2-8: ERROR: missing put_device; call of_find_device_by_node on line 152, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/ethernet/freescale/fman/mac.c:206:2-8: ERROR: missing put_device; call of_find_device_by_node on line 152, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/ethernet/freescale/fman/mac.c:220:2-8: ERROR: missing put_device; call of_find_device_by_node on line 152, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/ethernet/freescale/fman/mac.c:226:2-8: ERROR: missing put_device; call of_find_device_by_node on line 152, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/ethernet/freescale/fman/mac.c:235:3-9: ERROR: missing put_device; call of_find_device_by_node on line 152, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/ethernet/freescale/fman/mac.c:273:2-8: ERROR: missing put_device; call of_find_device_by_node on line 152, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/ethernet/freescale/fman/mac.c:286:1-7: ERROR: missing put_device; call of_find_device_by_node on line 152, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/ethernet/freescale/fman/mac.c:290:1-7: ERROR: missing put_device; call of_find_device_by_node on line 152, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/ethernet/freescale/fman/mac.c:235:3-9: ERROR: missing put_device; call of_find_device_by_node on line 238, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/ethernet/freescale/fman/mac.c:273:2-8: ERROR: missing put_device; call of_find_device_by_node on line 238, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/ethernet/freescale/fman/mac.c:286:1-7: ERROR: missing put_device; call of_find_device_by_node on line 238, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/ethernet/freescale/fman/mac.c:290:1-7: ERROR: missing put_device; call of_find_device_by_node on line 238, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/dsa/mv88e6xxx/chip.c:1592:5-7: ERROR: invalid reference to the index variable of the iterator on line 1561 /home/cocci/testing/drivers/net/dsa/mv88e6xxx/chip.c:1592:38-40: ERROR: invalid reference to the index variable of the iterator on line 1561 /home/cocci/testing/drivers/net/dsa/mv88e6xxx/chip.c:1592:5-7: ERROR: invalid reference to the index variable of the iterator on line 1573 /home/cocci/testing/drivers/net/dsa/mv88e6xxx/chip.c:1592:38-40: ERROR: invalid reference to the index variable of the iterator on line 1573 /home/cocci/testing/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c:577:9-32: duplicated argument to & or | /home/cocci/testing/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c:577:35-58: duplicated argument to & or |