Please check for false positives in the output before submitting a patch. When using "patch" mode, carefully review the patch before submitting it. /home/cocci/testing/kernel/fork.c:943:14-33: WARNING: atomic_dec_and_test variation before object free at line 945. /home/cocci/testing/kernel/fork.c:1385:5-24: WARNING: atomic_dec_and_test variation before object free at line 1387. warning: line 140: should noop_llseek be a metavariable? warning: line 222: should nonseekable_open be a metavariable? warning: line 289: should nonseekable_open be a metavariable? warning: line 337: should nonseekable_open be a metavariable? /home/cocci/testing/drivers/net/ethernet/realtek/r8169_main.c:5668:7-23: opportunity for str_enabled_disabled(tp -> dash_enabled) /home/cocci/testing/drivers/net/ethernet/faraday/ftgmac100.c:1762:5-16: opportunity for str_up_down(nd -> link_up) /home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_ptp.c:229:3-5: opportunity for str_enable_disable(en) /home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c:1221:5-14: opportunity for str_on_off(old_state) /home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c:1221:31-38: opportunity for str_on_off(tx_push) /home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c:8013:3-5: opportunity for str_enable_disable(en) /home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c:11213:3-39: opportunity for str_enable_disable(handle -> kinfo . tc_info . dcb_ets_active) /home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c:11215:3-38: opportunity for str_enable_disable(handle -> kinfo . tc_info . mqprio_active) /home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c:11989:7-13: opportunity for str_on_off(enable) /home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c:11997:7-13: opportunity for str_on_off(enable) /home/cocci/testing/net/core/sock.c:4159:1-29: opportunity for str_yes_no(proto_memory_pressure ( proto )) /home/cocci/testing/drivers/net/tun.c:3200:6-9: opportunity for str_enabled_disabled(arg) /home/cocci/testing/drivers/block/mtip32xx/mtip32xx.c:609:5-40: opportunity for str_write_read(fis -> command == ATA_CMD_FPDMA_WRITE) /home/cocci/testing/drivers/net/ethernet/cisco/enic/enic_res.c:94:2-25: opportunity for str_yes_no(ENIC_SETTING ( enic , LRO )) /home/cocci/testing/drivers/net/ethernet/cisco/enic/enic_res.c:95:2-25: opportunity for str_yes_no(ENIC_SETTING ( enic , RSS )) /home/cocci/testing/drivers/net/ethernet/cisco/enic/enic_res.c:92:2-28: opportunity for str_yes_no(ENIC_SETTING ( enic , RXCSUM )) /home/cocci/testing/drivers/net/ethernet/cisco/enic/enic_res.c:93:2-25: opportunity for str_yes_no(ENIC_SETTING ( enic , TSO )) /home/cocci/testing/drivers/net/ethernet/cisco/enic/enic_res.c:91:2-28: opportunity for str_yes_no(ENIC_SETTING ( enic , TXCSUM )) /home/cocci/testing/drivers/net/phy/phylink.c:1818:49-51: opportunity for str_up_down(up) /home/cocci/testing/drivers/net/phy/phylink.c:2139:39-41: opportunity for str_up_down(up) /home/cocci/testing/drivers/net/ethernet/intel/igb/igb_main.c:1833:5-21: opportunity for str_enabled_disabled(ring -> cbs_enable) /home/cocci/testing/drivers/net/ethernet/intel/igb/igb_main.c:1834:5-28: opportunity for str_enabled_disabled(ring -> launchtime_enable) /home/cocci/testing/drivers/net/ethernet/intel/igb/igb_main.c:1958:34-61: opportunity for str_enabled_disabled(( is_fqtss_enabled ( adapter ) )) /home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c:664:28-19: opportunity for str_on_off(readl_relaxed ( ring -> tqp -> io_base + HNS3_RING_EN_REG )) /home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c:767:28-19: opportunity for str_on_off(readl_relaxed ( ring -> tqp -> io_base + HNS3_RING_EN_REG )) /home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c:668:29-23: opportunity for str_on_off(readl_relaxed ( ring -> tqp -> io_base + HNS3_RING_RX_EN_REG )) /home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c:771:29-23: opportunity for str_on_off(readl_relaxed ( ring -> tqp -> io_base + HNS3_RING_TX_EN_REG )) /home/cocci/testing/drivers/net/ethernet/freescale/enetc/enetc_pf.c:928:1-7: ERROR: missing put_device; call of_find_device_by_node on line 922, but without a corresponding object release within this function. /home/cocci/testing/drivers/net/ethernet/intel/igb/igb_main.c:7880:3-8: ERROR: invalid reference to the index variable of the iterator on line 7872 /home/cocci/testing/kernel/exit.c:515:18-19: ERROR: invalid reference to the index variable of the iterator on line 508 /home/cocci/testing/drivers/net/wireless/ath/ath11k/dp_rx.c:4407:3-6: ERROR: invalid reference to the index variable of the iterator on line 4397 /home/cocci/testing/drivers/net/wireless/ath/ath11k/dp_rx.c:4407:29-32: ERROR: invalid reference to the index variable of the iterator on line 4397 /home/cocci/testing/drivers/net/dsa/mv88e6xxx/chip.c:1592:5-7: ERROR: invalid reference to the index variable of the iterator on line 1561 /home/cocci/testing/drivers/net/dsa/mv88e6xxx/chip.c:1592:38-40: ERROR: invalid reference to the index variable of the iterator on line 1561 /home/cocci/testing/drivers/net/dsa/mv88e6xxx/chip.c:1592:5-7: ERROR: invalid reference to the index variable of the iterator on line 1573 /home/cocci/testing/drivers/net/dsa/mv88e6xxx/chip.c:1592:38-40: ERROR: invalid reference to the index variable of the iterator on line 1573 /home/cocci/testing/drivers/net/team/team_core.c:2746:12-16: ERROR: invalid reference to the index variable of the iterator on line 2747 /home/cocci/testing/drivers/net/ethernet/faraday/ftgmac100.c:1373:0-1: preceding lock on line 1338 /home/cocci/testing/drivers/net/ethernet/faraday/ftgmac100.c:1373:0-1: preceding lock on line 1340 /home/cocci/testing/net/netfilter/x_tables.c:1247:3-9: preceding lock on line 1244 /home/cocci/testing/net/netfilter/x_tables.c:1275:3-9: preceding lock on line 1244 /home/cocci/testing/net/netfilter/x_tables.c:1275:3-9: preceding lock on line 1265 /home/cocci/testing/kernel/exit.c:1652:3-9: preceding lock on line 1647 /home/cocci/testing/kernel/exit.c:1659:4-10: preceding lock on line 1647 /home/cocci/testing/kernel/exit.c:1663:4-10: preceding lock on line 1647 /home/cocci/testing/kernel/exit.c:531:1-7: preceding lock on line 497 /home/cocci/testing/net/ethtool/ioctl.c:1607:1-7: preceding lock on line 1462 /home/cocci/testing/drivers/net/tun.c:2035:1-7: preceding lock on line 1839 /home/cocci/testing/drivers/net/wireless/realtek/rtw89/pci.c:332:5-8: Unneeded variable: "cnt". Return "1" on line 393