Please check for false positives in the output before submitting a patch. When using "patch" mode, carefully review the patch before submitting it. /home/cocci/testing/drivers/net/ethernet/broadcom/bnxt/bnxt.c:5587:6-25: WARNING: atomic_dec_and_test variation before object free at line 5594. warning: line 140: should noop_llseek be a metavariable? warning: line 222: should nonseekable_open be a metavariable? warning: line 289: should nonseekable_open be a metavariable? warning: line 337: should nonseekable_open be a metavariable? /home/cocci/testing/drivers/net/ethernet/intel/igb/igb_main.c:1829:5-21: opportunity for str_enabled_disabled(ring -> cbs_enable) /home/cocci/testing/drivers/net/ethernet/intel/igb/igb_main.c:1830:5-28: opportunity for str_enabled_disabled(ring -> launchtime_enable) /home/cocci/testing/drivers/net/ethernet/intel/igb/igb_main.c:1954:34-61: opportunity for str_enabled_disabled(( is_fqtss_enabled ( adapter ) )) /home/cocci/testing/drivers/net/ethernet/cisco/enic/enic_res.c:94:2-25: opportunity for str_yes_no(ENIC_SETTING ( enic , LRO )) /home/cocci/testing/drivers/net/ethernet/cisco/enic/enic_res.c:95:2-25: opportunity for str_yes_no(ENIC_SETTING ( enic , RSS )) /home/cocci/testing/drivers/net/ethernet/cisco/enic/enic_res.c:92:2-28: opportunity for str_yes_no(ENIC_SETTING ( enic , RXCSUM )) /home/cocci/testing/drivers/net/ethernet/cisco/enic/enic_res.c:93:2-25: opportunity for str_yes_no(ENIC_SETTING ( enic , TSO )) /home/cocci/testing/drivers/net/ethernet/cisco/enic/enic_res.c:91:2-28: opportunity for str_yes_no(ENIC_SETTING ( enic , TXCSUM )) /home/cocci/testing/net/ieee802154/trace.h:38:24-28: opportunity for str_true_false(( bo )) /home/cocci/testing/drivers/net/ethernet/faraday/ftgmac100.c:1762:5-16: opportunity for str_up_down(nd -> link_up) /home/cocci/testing/drivers/block/mtip32xx/mtip32xx.c:609:5-40: opportunity for str_write_read(fis -> command == ATA_CMD_FPDMA_WRITE) /home/cocci/testing/drivers/net/phy/phylink.c:1825:49-51: opportunity for str_up_down(up) /home/cocci/testing/drivers/net/phy/phylink.c:2146:39-41: opportunity for str_up_down(up) /home/cocci/testing/drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c:3420:6-23: opportunity for str_enabled_disabled(udp_rss_requested) /home/cocci/testing/drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c:3429:6-23: opportunity for str_enabled_disabled(udp_rss_requested) /home/cocci/testing/drivers/net/ethernet/broadcom/bnxt/bnxt.c:11158:8-32: opportunity for str_on_off(( fec & BNXT_FEC_AUTONEG )) /home/cocci/testing/net/sched/sch_etf.c:373:3-28: opportunity for str_on_off(DEADLINE_MODE_IS_ON ( qopt )) /home/cocci/testing/net/sched/sch_etf.c:372:3-22: opportunity for str_on_off(OFFLOAD_IS_ON ( qopt )) /home/cocci/testing/drivers/net/ethernet/broadcom/genet/bcmgenet.c:3534:4-19: opportunity for str_enabled_disabled(intsts & intmsk) /home/cocci/testing/include/net/flow_offload.h:378:6-7: ERROR: iterator variable bound on line 377 cannot be NULL /home/cocci/testing/drivers/net/wireless/ath/ath11k/dp_rx.c:4407:3-6: ERROR: invalid reference to the index variable of the iterator on line 4397 /home/cocci/testing/drivers/net/wireless/ath/ath11k/dp_rx.c:4407:29-32: ERROR: invalid reference to the index variable of the iterator on line 4397 /home/cocci/testing/drivers/net/dsa/mv88e6xxx/chip.c:1592:5-7: ERROR: invalid reference to the index variable of the iterator on line 1561 /home/cocci/testing/drivers/net/dsa/mv88e6xxx/chip.c:1592:38-40: ERROR: invalid reference to the index variable of the iterator on line 1561 /home/cocci/testing/drivers/net/dsa/mv88e6xxx/chip.c:1592:5-7: ERROR: invalid reference to the index variable of the iterator on line 1573 /home/cocci/testing/drivers/net/dsa/mv88e6xxx/chip.c:1592:38-40: ERROR: invalid reference to the index variable of the iterator on line 1573 /home/cocci/testing/drivers/net/ethernet/broadcom/genet/bcmgenet.c:1474:5-13: ERROR: invalid reference to the index variable of the iterator on line 1452 /home/cocci/testing/drivers/net/ethernet/intel/igb/igb_main.c:7876:3-8: ERROR: invalid reference to the index variable of the iterator on line 7868 /home/cocci/testing/net/netfilter/x_tables.c:1246:3-9: preceding lock on line 1243 /home/cocci/testing/net/netfilter/x_tables.c:1273:3-9: preceding lock on line 1243 /home/cocci/testing/net/netfilter/x_tables.c:1273:3-9: preceding lock on line 1266 /home/cocci/testing/drivers/net/ethernet/faraday/ftgmac100.c:1373:0-1: preceding lock on line 1338 /home/cocci/testing/drivers/net/ethernet/faraday/ftgmac100.c:1373:0-1: preceding lock on line 1340 /home/cocci/testing/net/ethtool/ioctl.c:1607:1-7: preceding lock on line 1462 /home/cocci/testing/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c:46:85-86: WARNING: Use ARRAY_SIZE /home/cocci/testing/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c:69:63-64: WARNING: Use ARRAY_SIZE /home/cocci/testing/drivers/net/wireless/realtek/rtw89/pci.c:332:5-8: Unneeded variable: "cnt". Return "1" on line 393