Please check for false positives in the output before submitting a patch. When using "patch" mode, carefully review the patch before submitting it. /home/cocci/testing/drivers/net/ethernet/broadcom/bnxt/bnxt.c:5680:6-25: WARNING: atomic_dec_and_test variation before object free at line 5687. warning: line 140: should noop_llseek be a metavariable? warning: line 222: should nonseekable_open be a metavariable? warning: line 289: should nonseekable_open be a metavariable? warning: line 337: should nonseekable_open be a metavariable? /home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_ptp.c:229:3-5: opportunity for str_enable_disable(en) /home/cocci/testing/drivers/net/ethernet/intel/igb/igb_main.c:1833:5-21: opportunity for str_enabled_disabled(ring -> cbs_enable) /home/cocci/testing/drivers/net/ethernet/intel/igb/igb_main.c:1834:5-28: opportunity for str_enabled_disabled(ring -> launchtime_enable) /home/cocci/testing/drivers/net/ethernet/intel/igb/igb_main.c:1958:34-61: opportunity for str_enabled_disabled(( is_fqtss_enabled ( adapter ) )) /home/cocci/testing/drivers/net/phy/phylink.c:1818:49-51: opportunity for str_up_down(up) /home/cocci/testing/drivers/net/phy/phylink.c:2139:39-41: opportunity for str_up_down(up) /home/cocci/testing/drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c:3412:6-23: opportunity for str_enabled_disabled(udp_rss_requested) /home/cocci/testing/drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c:3421:6-23: opportunity for str_enabled_disabled(udp_rss_requested) /home/cocci/testing/drivers/net/ethernet/broadcom/bnxt/bnxt.c:11249:8-32: opportunity for str_on_off(( fec & BNXT_FEC_AUTONEG )) /home/cocci/testing/drivers/net/ethernet/broadcom/genet/bcmgenet.c:3534:4-19: opportunity for str_enabled_disabled(intsts & intmsk) /home/cocci/testing/drivers/net/ethernet/faraday/ftgmac100.c:1762:5-16: opportunity for str_up_down(nd -> link_up) /home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c:664:28-19: opportunity for str_on_off(readl_relaxed ( ring -> tqp -> io_base + HNS3_RING_EN_REG )) /home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c:767:28-19: opportunity for str_on_off(readl_relaxed ( ring -> tqp -> io_base + HNS3_RING_EN_REG )) /home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c:668:29-23: opportunity for str_on_off(readl_relaxed ( ring -> tqp -> io_base + HNS3_RING_RX_EN_REG )) /home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c:771:29-23: opportunity for str_on_off(readl_relaxed ( ring -> tqp -> io_base + HNS3_RING_TX_EN_REG )) /home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c:1221:5-14: opportunity for str_on_off(old_state) /home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c:1221:31-38: opportunity for str_on_off(tx_push) /home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c:8013:3-5: opportunity for str_enable_disable(en) /home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c:11213:3-39: opportunity for str_enable_disable(handle -> kinfo . tc_info . dcb_ets_active) /home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c:11215:3-38: opportunity for str_enable_disable(handle -> kinfo . tc_info . mqprio_active) /home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c:11989:7-13: opportunity for str_on_off(enable) /home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c:11997:7-13: opportunity for str_on_off(enable) /home/cocci/testing/include/net/flow_offload.h:378:6-7: ERROR: iterator variable bound on line 377 cannot be NULL /home/cocci/testing/drivers/net/dsa/mv88e6xxx/chip.c:1592:5-7: ERROR: invalid reference to the index variable of the iterator on line 1561 /home/cocci/testing/drivers/net/dsa/mv88e6xxx/chip.c:1592:38-40: ERROR: invalid reference to the index variable of the iterator on line 1561 /home/cocci/testing/drivers/net/dsa/mv88e6xxx/chip.c:1592:5-7: ERROR: invalid reference to the index variable of the iterator on line 1573 /home/cocci/testing/drivers/net/dsa/mv88e6xxx/chip.c:1592:38-40: ERROR: invalid reference to the index variable of the iterator on line 1573 /home/cocci/testing/drivers/net/ethernet/intel/igb/igb_main.c:7880:3-8: ERROR: invalid reference to the index variable of the iterator on line 7872 /home/cocci/testing/drivers/net/ethernet/broadcom/genet/bcmgenet.c:1474:5-13: ERROR: invalid reference to the index variable of the iterator on line 1452 /home/cocci/testing/net/netfilter/x_tables.c:1246:3-9: preceding lock on line 1243 /home/cocci/testing/net/netfilter/x_tables.c:1273:3-9: preceding lock on line 1243 /home/cocci/testing/net/netfilter/x_tables.c:1273:3-9: preceding lock on line 1266 /home/cocci/testing/drivers/net/ethernet/faraday/ftgmac100.c:1373:0-1: preceding lock on line 1338 /home/cocci/testing/drivers/net/ethernet/faraday/ftgmac100.c:1373:0-1: preceding lock on line 1340 /home/cocci/testing/net/ethtool/ioctl.c:1607:1-7: preceding lock on line 1462 /home/cocci/testing/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c:46:85-86: WARNING: Use ARRAY_SIZE /home/cocci/testing/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c:69:63-64: WARNING: Use ARRAY_SIZE