Please check for false positives in the output before submitting a patch. When using "patch" mode, carefully review the patch before submitting it. /home/cocci/testing/drivers/net/ethernet/broadcom/bnxt/bnxt.c:5587:6-25: WARNING: atomic_dec_and_test variation before object free at line 5594. warning: line 140: should noop_llseek be a metavariable? warning: line 222: should nonseekable_open be a metavariable? warning: line 289: should nonseekable_open be a metavariable? warning: line 337: should nonseekable_open be a metavariable? /home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_ptp.c:226:3-5: opportunity for str_enable_disable(en) /home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c:7987:3-5: opportunity for str_enable_disable(en) /home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c:11187:3-39: opportunity for str_enable_disable(handle -> kinfo . tc_info . dcb_ets_active) /home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c:11189:3-38: opportunity for str_enable_disable(handle -> kinfo . tc_info . mqprio_active) /home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c:11962:7-13: opportunity for str_on_off(enable) /home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c:11970:7-13: opportunity for str_on_off(enable) /home/cocci/testing/net/core/sock.c:4145:1-29: opportunity for str_yes_no(proto_memory_pressure ( proto )) /home/cocci/testing/drivers/net/phy/phylink.c:1825:49-51: opportunity for str_up_down(up) /home/cocci/testing/drivers/net/phy/phylink.c:2146:39-41: opportunity for str_up_down(up) /home/cocci/testing/drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c:3420:6-23: opportunity for str_enabled_disabled(udp_rss_requested) /home/cocci/testing/drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c:3429:6-23: opportunity for str_enabled_disabled(udp_rss_requested) /home/cocci/testing/drivers/net/ethernet/broadcom/bnxt/bnxt.c:11158:8-32: opportunity for str_on_off(( fec & BNXT_FEC_AUTONEG )) /home/cocci/testing/drivers/net/ethernet/broadcom/genet/bcmgenet.c:3534:4-19: opportunity for str_enabled_disabled(intsts & intmsk) /home/cocci/testing/drivers/net/ethernet/faraday/ftgmac100.c:1762:5-16: opportunity for str_up_down(nd -> link_up) /home/cocci/testing/drivers/net/ethernet/intel/igb/igb_main.c:1829:5-21: opportunity for str_enabled_disabled(ring -> cbs_enable) /home/cocci/testing/drivers/net/ethernet/intel/igb/igb_main.c:1830:5-28: opportunity for str_enabled_disabled(ring -> launchtime_enable) /home/cocci/testing/drivers/net/ethernet/intel/igb/igb_main.c:1954:34-61: opportunity for str_enabled_disabled(( is_fqtss_enabled ( adapter ) )) /home/cocci/testing/drivers/net/ethernet/intel/i40e/i40e_main.c:2849:5-16: opportunity for str_on_off(cur_promisc) /home/cocci/testing/drivers/net/ethernet/intel/i40e/i40e_main.c:11149:4-19: opportunity for str_on_off(pf -> cur_promisc) /home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c:664:28-19: opportunity for str_on_off(readl_relaxed ( ring -> tqp -> io_base + HNS3_RING_EN_REG )) /home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c:767:28-19: opportunity for str_on_off(readl_relaxed ( ring -> tqp -> io_base + HNS3_RING_EN_REG )) /home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c:668:29-23: opportunity for str_on_off(readl_relaxed ( ring -> tqp -> io_base + HNS3_RING_RX_EN_REG )) /home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c:771:29-23: opportunity for str_on_off(readl_relaxed ( ring -> tqp -> io_base + HNS3_RING_TX_EN_REG )) /home/cocci/testing/drivers/net/ethernet/realtek/r8169_main.c:5668:7-23: opportunity for str_enabled_disabled(tp -> dash_enabled) /home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c:1221:5-14: opportunity for str_on_off(old_state) /home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c:1221:31-38: opportunity for str_on_off(tx_push) /home/cocci/testing/drivers/net/ethernet/intel/i40e/i40e_main.c:15830:2-8: ERROR: missing iounmap; ioremap on line 15677 and execution via conditional on line 15829 /home/cocci/testing/include/net/flow_offload.h:378:6-7: ERROR: iterator variable bound on line 377 cannot be NULL /home/cocci/testing/drivers/net/ethernet/broadcom/genet/bcmgenet.c:1474:5-13: ERROR: invalid reference to the index variable of the iterator on line 1452 /home/cocci/testing/drivers/net/ethernet/intel/igb/igb_main.c:7876:3-8: ERROR: invalid reference to the index variable of the iterator on line 7868 /home/cocci/testing/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c:4487:1-7: preceding lock on line 4389 /home/cocci/testing/net/netfilter/x_tables.c:1246:3-9: preceding lock on line 1243 /home/cocci/testing/net/netfilter/x_tables.c:1273:3-9: preceding lock on line 1243 /home/cocci/testing/net/netfilter/x_tables.c:1273:3-9: preceding lock on line 1266 /home/cocci/testing/drivers/net/ethernet/faraday/ftgmac100.c:1373:0-1: preceding lock on line 1338 /home/cocci/testing/drivers/net/ethernet/faraday/ftgmac100.c:1373:0-1: preceding lock on line 1340 /home/cocci/testing/drivers/net/ethernet/intel/ice/ice_main.c:9309:2-8: preceding lock on line 9289 /home/cocci/testing/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c:2782:1-7: WARNING: do_div() does a 64-by-32 division, please consider using div64_ul instead. /home/cocci/testing/drivers/net/ethernet/microchip/sparx5/sparx5_tc_flower.c:1528:5-8: Unneeded variable: "err". Return "- ENOENT" on line 1543