Please check for false positives in the output before submitting a patch.
When using "patch" mode, carefully review the patch before submitting it.

warning: line 140: should noop_llseek be a metavariable?
warning: line 222: should nonseekable_open be a metavariable?
warning: line 289: should nonseekable_open be a metavariable?
warning: line 337: should nonseekable_open be a metavariable?
/home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c:1221:5-14: opportunity for str_on_off(old_state)
/home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c:1221:31-38: opportunity for str_on_off(tx_push)
/home/cocci/testing/net/core/sock.c:4149:1-29: opportunity for str_yes_no(proto_memory_pressure ( proto ))
/home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c:8013:3-5: opportunity for str_enable_disable(en)
/home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c:11213:3-39: opportunity for str_enable_disable(handle -> kinfo . tc_info . dcb_ets_active)
/home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c:11215:3-38: opportunity for str_enable_disable(handle -> kinfo . tc_info . mqprio_active)
/home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c:11989:7-13: opportunity for str_on_off(enable)
/home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c:11997:7-13: opportunity for str_on_off(enable)
/home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_ptp.c:229:3-5: opportunity for str_enable_disable(en)
/home/cocci/testing/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c:3004:6-9: opportunity for str_enable_disable(val)
/home/cocci/testing/drivers/net/ethernet/cisco/enic/enic_res.c:94:2-25: opportunity for str_yes_no(ENIC_SETTING ( enic , LRO ))
/home/cocci/testing/drivers/net/ethernet/cisco/enic/enic_res.c:95:2-25: opportunity for str_yes_no(ENIC_SETTING ( enic , RSS ))
/home/cocci/testing/drivers/net/ethernet/cisco/enic/enic_res.c:92:2-28: opportunity for str_yes_no(ENIC_SETTING ( enic , RXCSUM ))
/home/cocci/testing/drivers/net/ethernet/cisco/enic/enic_res.c:93:2-25: opportunity for str_yes_no(ENIC_SETTING ( enic , TSO ))
/home/cocci/testing/drivers/net/ethernet/cisco/enic/enic_res.c:91:2-28: opportunity for str_yes_no(ENIC_SETTING ( enic , TXCSUM ))
/home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c:664:28-19: opportunity for str_on_off(readl_relaxed ( ring -> tqp -> io_base + HNS3_RING_EN_REG ))
/home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c:767:28-19: opportunity for str_on_off(readl_relaxed ( ring -> tqp -> io_base + HNS3_RING_EN_REG ))
/home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c:668:29-23: opportunity for str_on_off(readl_relaxed ( ring -> tqp -> io_base + HNS3_RING_RX_EN_REG ))
/home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c:771:29-23: opportunity for str_on_off(readl_relaxed ( ring -> tqp -> io_base + HNS3_RING_TX_EN_REG ))
/home/cocci/testing/include/net/flow_offload.h:378:6-7: ERROR: iterator variable bound on line 377 cannot be NULL
/home/cocci/testing/drivers/net/ethernet/microchip/sparx5/sparx5_tc_flower.c:1533:5-8: Unneeded variable: "err". Return "- ENOENT" on line 1548
/home/cocci/testing/drivers/net/ethernet/stmicro/stmmac/dwmac-thead.c:79:2-3: Unneeded semicolon
/home/cocci/testing/drivers/net/ethernet/stmicro/stmmac/dwmac-thead.c:104:2-3: Unneeded semicolon