New output added --- /home/cocci/outputs/results/837981/old-filtered 2024-10-30 03:19:32.582054414 -0700 +++ /home/cocci/outputs/results/837981/new-filtered 2024-10-30 03:19:32.612054599 -0700 @@ -9 +9,4 @@ -/home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_ptp.c:226:3-5: opportunity for str_enable_disable(en) +/home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c:1221:5-14: opportunity for str_on_off(old_state) +/home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c:1221:31-38: opportunity for str_on_off(tx_push) +/home/cocci/testing/drivers/net/ethernet/hisilicon/hibmcge/hbg_debugfs.c:21:33-40: opportunity for str_true_false(( state )) +/home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_ptp.c:229:3-5: opportunity for str_enable_disable(en) @@ -14,9 +17,7 @@ -/home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c:7987:3-5: opportunity for str_enable_disable(en) -/home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c:11187:3-39: opportunity for str_enable_disable(handle -> kinfo . tc_info . dcb_ets_active) -/home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c:11189:3-38: opportunity for str_enable_disable(handle -> kinfo . tc_info . mqprio_active) -/home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c:11962:7-13: opportunity for str_on_off(enable) -/home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c:11970:7-13: opportunity for str_on_off(enable) -/home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c:1221:5-14: opportunity for str_on_off(old_state) -/home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c:1221:31-38: opportunity for str_on_off(tx_push) -/home/cocci/testing/net/core/sock.c:4145:1-29: opportunity for str_yes_no(proto_memory_pressure ( proto )) -/home/cocci/testing/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c:3008:6-9: opportunity for str_enable_disable(val) +/home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c:8013:3-5: opportunity for str_enable_disable(en) +/home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c:11213:3-39: opportunity for str_enable_disable(handle -> kinfo . tc_info . dcb_ets_active) +/home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c:11215:3-38: opportunity for str_enable_disable(handle -> kinfo . tc_info . mqprio_active) +/home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c:11989:7-13: opportunity for str_on_off(enable) +/home/cocci/testing/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c:11997:7-13: opportunity for str_on_off(enable) +/home/cocci/testing/net/core/sock.c:4149:1-29: opportunity for str_yes_no(proto_memory_pressure ( proto )) +/home/cocci/testing/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c:3004:6-9: opportunity for str_enable_disable(val) @@ -29,5 +30,5 @@ -/home/cocci/testing/drivers/net/dsa/mv88e6xxx/chip.c:1592:5-7: ERROR: invalid reference to the index variable of the iterator on line 1561 -/home/cocci/testing/drivers/net/dsa/mv88e6xxx/chip.c:1592:38-40: ERROR: invalid reference to the index variable of the iterator on line 1561 -/home/cocci/testing/drivers/net/dsa/mv88e6xxx/chip.c:1592:5-7: ERROR: invalid reference to the index variable of the iterator on line 1573 -/home/cocci/testing/drivers/net/dsa/mv88e6xxx/chip.c:1592:38-40: ERROR: invalid reference to the index variable of the iterator on line 1573 -/home/cocci/testing/drivers/net/ethernet/microchip/sparx5/sparx5_tc_flower.c:1528:5-8: Unneeded variable: "err". Return "- ENOENT" on line 1543 +/home/cocci/testing/drivers/net/dsa/mv88e6xxx/chip.c:1581:5-7: ERROR: invalid reference to the index variable of the iterator on line 1550 +/home/cocci/testing/drivers/net/dsa/mv88e6xxx/chip.c:1581:38-40: ERROR: invalid reference to the index variable of the iterator on line 1550 +/home/cocci/testing/drivers/net/dsa/mv88e6xxx/chip.c:1581:5-7: ERROR: invalid reference to the index variable of the iterator on line 1562 +/home/cocci/testing/drivers/net/dsa/mv88e6xxx/chip.c:1581:38-40: ERROR: invalid reference to the index variable of the iterator on line 1562 +/home/cocci/testing/drivers/net/ethernet/microchip/sparx5/sparx5_tc_flower.c:1533:5-8: Unneeded variable: "err". Return "- ENOENT" on line 1548 Per-file breakdown --- /tmp/tmp.lkau2tlsov 2024-10-30 03:19:32.622054658 -0700 +++ /tmp/tmp.zB4MVWNCqp 2024-10-30 03:19:32.622054658 -0700 @@ -3,0 +4 @@ + 1 /drivers/net/ethernet/hisilicon/hibmcge/hbg_debugfs.c