Please check for false positives in the output before submitting a patch. When using "patch" mode, carefully review the patch before submitting it. /home/cocci/testing/drivers/net/ethernet/broadcom/bnxt/bnxt.c:5586:6-25: WARNING: atomic_dec_and_test variation before object free at line 5593. /home/cocci/testing/drivers/net/ethernet/samsung/sxgbe/sxgbe_platform.c:116:2-9: line 116 is redundant because platform_get_irq() already prints an error /home/cocci/testing/drivers/net/ethernet/samsung/sxgbe/sxgbe_platform.c:127:3-10: line 127 is redundant because platform_get_irq() already prints an error /home/cocci/testing/drivers/net/ethernet/samsung/sxgbe/sxgbe_platform.c:135:3-10: line 135 is redundant because platform_get_irq() already prints an error /home/cocci/testing/drivers/net/ethernet/samsung/sxgbe/sxgbe_platform.c:142:2-9: line 142 is redundant because platform_get_irq() already prints an error warning: line 140: should noop_llseek be a metavariable? warning: line 222: should nonseekable_open be a metavariable? warning: line 289: should nonseekable_open be a metavariable? warning: line 337: should nonseekable_open be a metavariable? /home/cocci/testing/drivers/net/ethernet/intel/i40e/i40e_main.c:15839:2-8: ERROR: missing iounmap; ioremap on line 15686 and execution via conditional on line 15838 /home/cocci/testing/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c:6221:9-13: ERROR: invalid reference to the index variable of the iterator on line 6213 /home/cocci/testing/drivers/net/ethernet/intel/igb/igb_main.c:7876:3-8: ERROR: invalid reference to the index variable of the iterator on line 7868 /home/cocci/testing/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c:6425:1-7: preceding lock on line 6386 /home/cocci/testing/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c:6562:1-7: preceding lock on line 6455 /home/cocci/testing/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c:4474:1-7: preceding lock on line 4376 /home/cocci/testing/drivers/net/ethernet/intel/ice/ice_main.c:9313:2-8: preceding lock on line 9293 /home/cocci/testing/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c:46:85-86: WARNING: Use ARRAY_SIZE /home/cocci/testing/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c:69:63-64: WARNING: Use ARRAY_SIZE /home/cocci/testing/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c:2769:1-7: WARNING: do_div() does a 64-by-32 division, please consider using div64_ul instead. /home/cocci/testing/net/ipv4/igmp.c:598:12-21: ERROR: pmc is NULL but dereferenced. /home/cocci/testing/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c:577:9-32: duplicated argument to & or | /home/cocci/testing/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c:577:35-58: duplicated argument to & or | /home/cocci/testing/drivers/net/ethernet/moxa/moxart_ether.c:468:5-8: WARNING: Unsigned expression compared with zero: irq <= 0 /home/cocci/testing/drivers/net/ethernet/samsung/sxgbe/sxgbe_platform.c:134:6-26: WARNING: Unsigned expression compared with zero: priv -> rxq [ i ] -> irq_no <= 0 /home/cocci/testing/drivers/net/ethernet/samsung/sxgbe/sxgbe_platform.c:126:6-26: WARNING: Unsigned expression compared with zero: priv -> txq [ i ] -> irq_no <= 0