New warnings added --- /home/cocci/outputs/results/858861/old-filtered 2024-11-13 14:33:59.608950180 -0800 +++ /home/cocci/outputs/results/858861/new-filtered 2024-11-13 14:33:59.638950345 -0800 @@ -5 +5,2 @@ -/home/cocci/testing/drivers/net/ethernet/broadcom/bnxt/bnxt.c:5586:6-25: WARNING: atomic_dec_and_test variation before object free at line 5593. +/home/cocci/testing/drivers/net/wireless/ath/ath12k/mac.c:3605:12-34: WARNING: casting value returned by memory allocation function to (struct ath12k_link_vif *) is useless. +/home/cocci/testing/drivers/net/ethernet/broadcom/bnxt/bnxt.c:5592:6-25: WARNING: atomic_dec_and_test variation before object free at line 5599. @@ -11 +11,0 @@ -/home/cocci/testing/drivers/net/wireless/ath/ath12k/wmi.c:7398:30-35: ERROR: invalid reference to the index variable of the iterator on line 7380 @@ -13,5 +13,3 @@ -/home/cocci/testing/drivers/net/wireless/ath/ath12k/dp_rx.c:3958:3-6: ERROR: invalid reference to the index variable of the iterator on line 3948 -/home/cocci/testing/drivers/net/wireless/ath/ath12k/dp_rx.c:3958:29-32: ERROR: invalid reference to the index variable of the iterator on line 3948 -/home/cocci/testing/drivers/net/wireless/realtek/rtw89/mac80211.c:1381:2-8: preceding lock on line 1374 -/home/cocci/testing/net/ethtool/ioctl.c:1607:1-7: preceding lock on line 1462 -/home/cocci/testing/net/smc/af_smc.c:2554:0-1: preceding lock on line 2481 +/home/cocci/testing/drivers/net/wireless/ath/ath12k/wmi.c:7402:30-35: ERROR: invalid reference to the index variable of the iterator on line 7384 +/home/cocci/testing/drivers/net/wireless/ath/ath12k/dp_rx.c:3962:3-6: ERROR: invalid reference to the index variable of the iterator on line 3952 +/home/cocci/testing/drivers/net/wireless/ath/ath12k/dp_rx.c:3962:29-32: ERROR: invalid reference to the index variable of the iterator on line 3952 @@ -18,0 +17 @@ +/home/cocci/testing/net/ethtool/ioctl.c:1612:1-7: preceding lock on line 1467 @@ -23 +21,0 @@ -/home/cocci/testing/drivers/net/wireless/intel/iwlwifi/fw/api/d3.h:943:4-15: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) @@ -26,0 +25,12 @@ +/home/cocci/testing/drivers/net/wireless/intel/iwlwifi/fw/api/d3.h:1002:4-15: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) +/home/cocci/testing/drivers/net/wireless/realtek/rtw88/coex.c:1504:14-15: WARNING: sum of probable bitmasks, consider | +/home/cocci/testing/drivers/net/wireless/realtek/rtw88/coex.c:1507:24-25: WARNING: sum of probable bitmasks, consider | +/home/cocci/testing/drivers/net/wireless/realtek/rtw88/coex.c:1508:24-25: WARNING: sum of probable bitmasks, consider | +/home/cocci/testing/drivers/net/wireless/realtek/rtw88/coex.c:1509:14-15: WARNING: sum of probable bitmasks, consider | +/home/cocci/testing/drivers/net/wireless/realtek/rtw88/coex.c:1512:35-36: WARNING: sum of probable bitmasks, consider | +/home/cocci/testing/drivers/net/wireless/realtek/rtw88/coex.c:1513:35-36: WARNING: sum of probable bitmasks, consider | +/home/cocci/testing/drivers/net/wireless/realtek/rtw88/coex.c:1514:14-15: WARNING: sum of probable bitmasks, consider | +/home/cocci/testing/drivers/net/wireless/realtek/rtw88/coex.c:1517:24-25: WARNING: sum of probable bitmasks, consider | +/home/cocci/testing/drivers/net/wireless/realtek/rtw88/coex.c:1518:24-25: WARNING: sum of probable bitmasks, consider | +/home/cocci/testing/drivers/net/wireless/realtek/rtw88/coex.c:1519:14-15: WARNING: sum of probable bitmasks, consider | +/home/cocci/testing/drivers/net/wireless/realtek/rtw88/coex.c:1525:35-36: WARNING: sum of probable bitmasks, consider | @@ -30,14 +40,3 @@ -/home/cocci/testing/drivers/net/wireless/intel/ipw2x00/libipw_rx.c:871:32-33: WARNING: sum of probable bitmasks, consider | -/home/cocci/testing/drivers/net/wireless/intel/ipw2x00/libipw_rx.c:886:32-33: WARNING: sum of probable bitmasks, consider | -/home/cocci/testing/drivers/net/wireless/realtek/rtw88/coex.c:1480:14-15: WARNING: sum of probable bitmasks, consider | -/home/cocci/testing/drivers/net/wireless/realtek/rtw88/coex.c:1483:24-25: WARNING: sum of probable bitmasks, consider | -/home/cocci/testing/drivers/net/wireless/realtek/rtw88/coex.c:1484:24-25: WARNING: sum of probable bitmasks, consider | -/home/cocci/testing/drivers/net/wireless/realtek/rtw88/coex.c:1485:14-15: WARNING: sum of probable bitmasks, consider | -/home/cocci/testing/drivers/net/wireless/realtek/rtw88/coex.c:1488:35-36: WARNING: sum of probable bitmasks, consider | -/home/cocci/testing/drivers/net/wireless/realtek/rtw88/coex.c:1489:35-36: WARNING: sum of probable bitmasks, consider | -/home/cocci/testing/drivers/net/wireless/realtek/rtw88/coex.c:1490:14-15: WARNING: sum of probable bitmasks, consider | -/home/cocci/testing/drivers/net/wireless/realtek/rtw88/coex.c:1493:24-25: WARNING: sum of probable bitmasks, consider | -/home/cocci/testing/drivers/net/wireless/realtek/rtw88/coex.c:1494:24-25: WARNING: sum of probable bitmasks, consider | -/home/cocci/testing/drivers/net/wireless/realtek/rtw88/coex.c:1495:14-15: WARNING: sum of probable bitmasks, consider | -/home/cocci/testing/drivers/net/wireless/realtek/rtw88/coex.c:1501:35-36: WARNING: sum of probable bitmasks, consider | -/home/cocci/testing/drivers/net/wireless/ath/ath12k/dp_mon.c:1244:24-34: Unneeded variable: "hal_status". Return "HAL_RX_MON_STATUS_BUF_DONE" on line 1260 +/home/cocci/testing/drivers/net/wireless/intel/ipw2x00/libipw_rx.c:871:34-35: WARNING: sum of probable bitmasks, consider | +/home/cocci/testing/drivers/net/wireless/intel/ipw2x00/libipw_rx.c:886:34-35: WARNING: sum of probable bitmasks, consider | +/home/cocci/testing/drivers/net/wireless/ath/ath12k/dp_mon.c:1251:24-34: Unneeded variable: "hal_status". Return "HAL_RX_MON_STATUS_BUF_DONE" on line 1267 @@ -45 +44 @@ -/home/cocci/testing/net/ipv4/igmp.c:597:12-21: ERROR: pmc is NULL but dereferenced. +/home/cocci/testing/net/ipv4/igmp.c:598:12-21: ERROR: pmc is NULL but dereferenced. @@ -52 +51 @@ -/home/cocci/testing/drivers/pci/pci.c:6885:6-10: duplicated argument to && or || +/home/cocci/testing/drivers/pci/pci.c:6875:6-10: duplicated argument to && or || Per-file breakdown --- /tmp/tmp.1LNzGmP3nU 2024-11-13 14:33:59.648950400 -0800 +++ /tmp/tmp.DT2SuhfXtX 2024-11-13 14:33:59.648950400 -0800 @@ -5,0 +6 @@ + 1 /drivers/net/wireless/ath/ath12k/mac.c @@ -15 +15,0 @@ - 1 /drivers/net/wireless/realtek/rtw89/mac80211.c @@ -20 +19,0 @@ - 1 /net/smc/af_smc.c