Please check for false positives in the output before submitting a patch. When using "patch" mode, carefully review the patch before submitting it. /home/cocci/testing/drivers/net/wireless/ath/ath12k/mac.c:3605:12-34: WARNING: casting value returned by memory allocation function to (struct ath12k_link_vif *) is useless. /home/cocci/testing/drivers/net/ethernet/broadcom/bnxt/bnxt.c:5592:6-25: WARNING: atomic_dec_and_test variation before object free at line 5599. warning: line 140: should noop_llseek be a metavariable? warning: line 222: should nonseekable_open be a metavariable? warning: line 289: should nonseekable_open be a metavariable? warning: line 337: should nonseekable_open be a metavariable? /home/cocci/testing/drivers/net/wireless/realtek/rtw89/debug.c:3295:29-32: ERROR: reference preceded by free on line 3288 /home/cocci/testing/drivers/net/wireless/ath/ath12k/wmi.c:7402:30-35: ERROR: invalid reference to the index variable of the iterator on line 7384 /home/cocci/testing/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c:687:1-6: ERROR: invalid reference to the index variable of the iterator on line 665 /home/cocci/testing/drivers/net/wireless/ath/ath12k/dp_rx.c:3962:3-6: ERROR: invalid reference to the index variable of the iterator on line 3952 /home/cocci/testing/drivers/net/wireless/ath/ath12k/dp_rx.c:3962:29-32: ERROR: invalid reference to the index variable of the iterator on line 3952 /home/cocci/testing/drivers/net/ethernet/intel/igb/igb_main.c:7876:3-8: ERROR: invalid reference to the index variable of the iterator on line 7868 /home/cocci/testing/drivers/net/wireless/ath/ath10k/mac.c:512:22-26: ERROR: invalid reference to the index variable of the iterator on line 498 /home/cocci/testing/drivers/net/ethernet/intel/i40e/i40e_ethtool.c:4096:32-37: ERROR: invalid reference to the index variable of the iterator on line 4050 /home/cocci/testing/drivers/net/ethernet/intel/ice/ice_ethtool.c:3997:1-7: preceding lock on line 3972 /home/cocci/testing/drivers/net/ethernet/intel/ice/ice_main.c:9340:2-8: preceding lock on line 9320 /home/cocci/testing/net/ethtool/ioctl.c:1612:1-7: preceding lock on line 1467 /home/cocci/testing/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c:4474:1-7: preceding lock on line 4376 /home/cocci/testing/drivers/net/wireless/realtek/rtw88/coex.h:42:52-57: WARNING: conversion to bool not needed here /home/cocci/testing/drivers/net/wireless/realtek/rtw88/coex.h:47:54-59: WARNING: conversion to bool not needed here /home/cocci/testing/drivers/net/wireless/realtek/rtw88/coex.h:52:51-56: WARNING: conversion to bool not needed here /home/cocci/testing/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c:2769:1-7: WARNING: do_div() does a 64-by-32 division, please consider using div64_ul instead. /home/cocci/testing/drivers/net/wireless/ath/ath6kl/wmi.h:1648:4-12: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) /home/cocci/testing/drivers/net/wireless/ath/ath6kl/wmi.h:2161:18-28: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) /home/cocci/testing/drivers/net/wireless/ath/ath6kl/wmi.h:2298:4-12: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) /home/cocci/testing/drivers/net/wireless/intel/iwlwifi/fw/api/d3.h:1002:4-15: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) /home/cocci/testing/drivers/net/wireless/intel/iwlwifi/pcie/trans.c:57:51-52: WARNING: sum of probable bitmasks, consider | /home/cocci/testing/drivers/net/wireless/intel/iwlwifi/pcie/trans.c:58:55-56: WARNING: sum of probable bitmasks, consider | /home/cocci/testing/drivers/net/wireless/intel/iwlwifi/pcie/trans.c:59:58-59: WARNING: sum of probable bitmasks, consider | /home/cocci/testing/drivers/net/wireless/intel/ipw2x00/libipw_rx.c:871:34-35: WARNING: sum of probable bitmasks, consider | /home/cocci/testing/drivers/net/wireless/intel/ipw2x00/libipw_rx.c:886:34-35: WARNING: sum of probable bitmasks, consider | /home/cocci/testing/drivers/net/wireless/realtek/rtw88/coex.c:1504:14-15: WARNING: sum of probable bitmasks, consider | /home/cocci/testing/drivers/net/wireless/realtek/rtw88/coex.c:1507:24-25: WARNING: sum of probable bitmasks, consider | /home/cocci/testing/drivers/net/wireless/realtek/rtw88/coex.c:1508:24-25: WARNING: sum of probable bitmasks, consider | /home/cocci/testing/drivers/net/wireless/realtek/rtw88/coex.c:1509:14-15: WARNING: sum of probable bitmasks, consider | /home/cocci/testing/drivers/net/wireless/realtek/rtw88/coex.c:1512:35-36: WARNING: sum of probable bitmasks, consider | /home/cocci/testing/drivers/net/wireless/realtek/rtw88/coex.c:1513:35-36: WARNING: sum of probable bitmasks, consider | /home/cocci/testing/drivers/net/wireless/realtek/rtw88/coex.c:1514:14-15: WARNING: sum of probable bitmasks, consider | /home/cocci/testing/drivers/net/wireless/realtek/rtw88/coex.c:1517:24-25: WARNING: sum of probable bitmasks, consider | /home/cocci/testing/drivers/net/wireless/realtek/rtw88/coex.c:1518:24-25: WARNING: sum of probable bitmasks, consider | /home/cocci/testing/drivers/net/wireless/realtek/rtw88/coex.c:1519:14-15: WARNING: sum of probable bitmasks, consider | /home/cocci/testing/drivers/net/wireless/realtek/rtw88/coex.c:1525:35-36: WARNING: sum of probable bitmasks, consider | /home/cocci/testing/drivers/net/wireless/realtek/rtw89/pci.c:332:5-8: Unneeded variable: "cnt". Return "1" on line 393 /home/cocci/testing/drivers/net/wireless/ath/ath12k/dp_mon.c:1251:24-34: Unneeded variable: "hal_status". Return "HAL_RX_MON_STATUS_BUF_DONE" on line 1267 /home/cocci/testing/net/ipv4/igmp.c:598:12-21: ERROR: pmc is NULL but dereferenced. /home/cocci/testing/drivers/net/wireless/ath/ath9k/ar9003_aic.c:115:42-46: duplicated argument to & or | /home/cocci/testing/drivers/net/wireless/ath/ath9k/ar9003_aic.c:116:3-7: duplicated argument to & or | /home/cocci/testing/drivers/net/wireless/ath/ath9k/ar9003_aic.c:117:42-46: duplicated argument to & or | /home/cocci/testing/drivers/net/wireless/ath/ath9k/ar9003_aic.c:118:3-7: duplicated argument to & or | /home/cocci/testing/drivers/net/wireless/ath/ath9k/ar9003_aic.c:119:42-46: duplicated argument to & or | /home/cocci/testing/drivers/net/wireless/ath/ath9k/ar9003_aic.c:120:3-7: duplicated argument to & or |