Please check for false positives in the output before submitting a patch. When using "patch" mode, carefully review the patch before submitting it. /home/cocci/testing/drivers/net/ethernet/broadcom/bnxt/bnxt.c:5690:6-25: WARNING: atomic_dec_and_test variation before object free at line 5697. warning: line 140: should noop_llseek be a metavariable? warning: line 222: should nonseekable_open be a metavariable? warning: line 289: should nonseekable_open be a metavariable? warning: line 337: should nonseekable_open be a metavariable? /home/cocci/testing/drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun_encap.c:37:2-9: WARNING: NULL check before dev_{put, hold} functions is not needed. /home/cocci/testing/drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun_encap.c:748:2-9: WARNING: NULL check before dev_{put, hold} functions is not needed. /home/cocci/testing/drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun_encap.c:783:2-9: WARNING: NULL check before dev_{put, hold} functions is not needed. /home/cocci/testing/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c:687:1-6: ERROR: invalid reference to the index variable of the iterator on line 665 /home/cocci/testing/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c:6224:9-13: ERROR: invalid reference to the index variable of the iterator on line 6216 /home/cocci/testing/drivers/net/ethernet/intel/igb/igb_main.c:7876:3-8: ERROR: invalid reference to the index variable of the iterator on line 7868 /home/cocci/testing/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c:6428:1-7: preceding lock on line 6389 /home/cocci/testing/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c:6565:1-7: preceding lock on line 6458 /home/cocci/testing/drivers/net/ethernet/intel/ice/ice_main.c:9344:2-8: preceding lock on line 9324 /home/cocci/testing/drivers/net/ethernet/mscc/ocelot_ptp.c:154:1-7: WARNING: do_div() does a 64-by-32 division, please consider using div64_long instead. /home/cocci/testing/drivers/net/ethernet/freescale/ucc_geth.h:644:4-8: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) /home/cocci/testing/drivers/net/ethernet/freescale/gianfar.c:2216:30-31: WARNING: sum of probable bitmasks, consider | /home/cocci/testing/drivers/net/ethernet/freescale/gianfar.c:3269:38-39: WARNING: sum of probable bitmasks, consider | /home/cocci/testing/drivers/net/ethernet/freescale/gianfar.c:1802:25-26: WARNING: sum of probable bitmasks, consider |