====================================== | [ 152.930543][ T250] ================================================================== | [ 152.930844][ T250] BUG: KASAN: use-after-free in page_pool_item_uninit (net/core/page_pool.c:523) | [ 152.931106][ T250] Read of size 8 at addr ffff88800abab008 by task rtnetlink.sh/250 | [ 152.931354][ T250] [ 152.931736][ T250] Hardware name: Bochs Bochs, BIOS Bochs 01/01/2011 [ 152.931947][ T250] Call Trace: [ 152.932084][ T250] [ 152.932177][ T250] dump_stack_lvl (lib/dump_stack.c:123) [ 152.932356][ T250] print_address_description.constprop.0 (mm/kasan/report.c:379) [ 152.932571][ T250] ? page_pool_item_uninit (net/core/page_pool.c:523) [ 152.932751][ T250] print_report (mm/kasan/report.c:490) [ 152.932921][ T250] ? kasan_addr_to_slab (./include/linux/mm.h:1295 mm/kasan/../slab.h:211 mm/kasan/common.c:38) [ 152.933093][ T250] kasan_report (mm/kasan/report.c:604) [ 152.933248][ T250] ? page_pool_item_uninit (net/core/page_pool.c:523) [ 152.933427][ T250] page_pool_item_uninit (net/core/page_pool.c:523) [ 152.933604][ T250] page_pool_release (net/core/page_pool.c:1431 net/core/page_pool.c:1484) [ 152.933780][ T250] ? __pfx_autoremove_wake_function (kernel/sched/wait.c:383) [ 152.934005][ T250] ? __pfx_page_pool_release (net/core/page_pool.c:1478) [ 152.934181][ T250] ? napi_disable (./arch/x86/include/asm/bitops.h:75 ./include/asm-generic/bitops/instrumented-atomic.h:42 net/core/dev.c:6832) [ 152.934371][ T250] page_pool_destroy (net/core/page_pool.c:1555) [ 152.934540][ T250] nsim_stop (drivers/net/netdevsim/netdev.c:469 drivers/net/netdevsim/netdev.c:483) netdevsim [ 152.934723][ T250] __dev_close_many (net/core/dev.c:1591) [ 152.934895][ T250] ? __pfx___dev_close_many (net/core/dev.c:1555) [ 152.935062][ T250] ? __pfx_validate_chain (kernel/locking/lockdep.c:3860) [ 152.935235][ T250] ? hlock_class (./arch/x86/include/asm/bitops.h:227 ./arch/x86/include/asm/bitops.h:239 ./include/asm-generic/bitops/instrumented-non-atomic.h:142 kernel/locking/lockdep.c:228) [ 152.935404][ T250] ? mark_lock (kernel/locking/lockdep.c:4727 (discriminator 3)) [ 152.935534][ T250] ? hlock_class (./arch/x86/include/asm/bitops.h:227 ./arch/x86/include/asm/bitops.h:239 ./include/asm-generic/bitops/instrumented-non-atomic.h:142 kernel/locking/lockdep.c:228) [ 152.935702][ T250] dev_close_many (net/core/dev.c:1618) [ 152.935871][ T250] ? __pfx_dev_close_many (net/core/dev.c:1608) [ 152.936041][ T250] unregister_netdevice_many_notify (net/core/dev.c:11562) [ 152.936253][ T250] ? __mutex_trylock_common (./arch/x86/include/asm/atomic64_64.h:101 ./include/linux/atomic/atomic-arch-fallback.h:4296 ./include/linux/atomic/atomic-long.h:1482 ./include/linux/atomic/atomic-instrumented.h:4458 kernel/locking/mutex.c:104) [ 152.936425][ T250] ? __pfx___mutex_trylock_common (kernel/locking/mutex.c:79) [ 152.936636][ T250] ? __pfx_unregister_netdevice_many_notify (net/core/dev.c:11529) [ 152.936847][ T250] ? lock_acquire (kernel/locking/lockdep.c:5822) [ 152.937018][ T250] ? __mutex_lock (./arch/x86/include/asm/preempt.h:94 kernel/locking/mutex.c:595 kernel/locking/mutex.c:735) [ 152.937190][ T250] ? nsim_destroy (drivers/net/netdevsim/netdev.c:827) netdevsim [ 152.937364][ T250] ? __pfx___mutex_lock (kernel/locking/mutex.c:734) [ 152.937532][ T250] unregister_netdevice_queue (net/core/dev.c:11524) [ 152.937704][ T250] ? __pfx_do_raw_spin_lock (kernel/locking/spinlock_debug.c:114) [ 152.937872][ T250] ? __pfx_unregister_netdevice_queue (net/core/dev.c:11513) [ 152.938084][ T250] nsim_destroy (drivers/net/netdevsim/netdev.c:832 (discriminator 2)) netdevsim [ 152.938261][ T250] __nsim_dev_port_del (drivers/net/netdevsim/dev.c:426 drivers/net/netdevsim/dev.c:1429) netdevsim [ 152.938476][ T250] nsim_dev_reload_destroy (drivers/net/netdevsim/dev.c:1438 drivers/net/netdevsim/dev.c:1661) netdevsim [ 152.938688][ T250] nsim_drv_remove (drivers/net/netdevsim/dev.c:1678) netdevsim [ 152.938865][ T250] device_release_driver_internal (drivers/base/dd.c:1275 drivers/base/dd.c:1296) [ 152.939092][ T250] ? klist_put (lib/klist.c:220) [ 152.939223][ T250] bus_remove_device (./include/linux/kobject.h:193 drivers/base/base.h:73 drivers/base/bus.c:583) [ 152.939399][ T250] device_del (drivers/base/core.c:3855) [ 152.939534][ T250] ? __pfx_device_del (drivers/base/core.c:3809) [ 152.939707][ T250] ? lock_acquire.part.0 (kernel/locking/lockdep.c:467 kernel/locking/lockdep.c:5851) [ 152.939881][ T250] ? kernfs_fop_write_iter (fs/kernfs/file.c:326) [ 152.940058][ T250] device_unregister (drivers/base/core.c:3772 drivers/base/core.c:3896) [ 152.940244][ T250] del_device_store (drivers/net/netdevsim/bus.c:230) netdevsim [ 152.940481][ T250] ? __pfx_del_device_store (drivers/net/netdevsim/bus.c:197) netdevsim [ 152.940709][ T250] ? __pfx_sysfs_kf_write (fs/sysfs/file.c:132) [ 152.940883][ T250] ? sysfs_file_ops (fs/sysfs/file.c:31 (discriminator 1)) [ 152.941061][ T250] ? __pfx_sysfs_kf_write (fs/sysfs/file.c:132) [ 152.941235][ T250] kernfs_fop_write_iter (fs/kernfs/file.c:334) [ 152.941418][ T250] vfs_write (fs/read_write.c:586 fs/read_write.c:679) [ 152.941552][ T250] ? __pfx_vfs_write (fs/read_write.c:660) [ 152.941727][ T250] ? __lock_release (kernel/locking/lockdep.c:5525) [ 152.941906][ T250] ? do_user_addr_fault (./include/linux/rcupdate.h:347 ./include/linux/rcupdate.h:880 ./include/linux/mm.h:742 arch/x86/mm/fault.c:1340) [ 152.942086][ T250] ? __pfx___up_read (kernel/locking/rwsem.c:1337) [ 152.942262][ T250] ksys_write (fs/read_write.c:731) [ 152.942393][ T250] ? __pfx_ksys_write (fs/read_write.c:721) [ 152.942577][ T250] ? do_user_addr_fault (./include/linux/rcupdate.h:882 ./include/linux/mm.h:742 arch/x86/mm/fault.c:1340) [ 152.942750][ T250] do_syscall_64 (arch/x86/entry/common.c:52 arch/x86/entry/common.c:83) [ 152.942919][ T250] entry_SYSCALL_64_after_hwframe (arch/x86/entry/entry_64.S:130) [ 152.943155][ T250] RIP: 0033:0x7f7080831b77 [ 152.943338][ T250] Code: 0b 00 f7 d8 64 89 02 48 c7 c0 ff ff ff ff eb b7 0f 1f 00 f3 0f 1e fa 64 8b 04 25 18 00 00 00 85 c0 75 10 b8 01 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 51 c3 48 83 ec 28 48 89 54 24 18 48 89 74 24 All code ======== 0: 0b 00 or (%rax),%eax 2: f7 d8 neg %eax 4: 64 89 02 mov %eax,%fs:(%rdx) 7: 48 c7 c0 ff ff ff ff mov $0xffffffffffffffff,%rax e: eb b7 jmp 0xffffffffffffffc7 10: 0f 1f 00 nopl (%rax) 13: f3 0f 1e fa endbr64 17: 64 8b 04 25 18 00 00 mov %fs:0x18,%eax 1e: 00 1f: 85 c0 test %eax,%eax 21: 75 10 jne 0x33 23: b8 01 00 00 00 mov $0x1,%eax 28: 0f 05 syscall 2a:* 48 3d 00 f0 ff ff cmp $0xfffffffffffff000,%rax <-- trapping instruction 30: 77 51 ja 0x83 32: c3 ret 33: 48 83 ec 28 sub $0x28,%rsp 37: 48 89 54 24 18 mov %rdx,0x18(%rsp) 3c: 48 rex.W 3d: 89 .byte 0x89 3e: 74 24 je 0x64 Code starting with the faulting instruction =========================================== 0: 48 3d 00 f0 ff ff cmp $0xfffffffffffff000,%rax 6: 77 51 ja 0x59 8: c3 ret 9: 48 83 ec 28 sub $0x28,%rsp d: 48 89 54 24 18 mov %rdx,0x18(%rsp) 12: 48 rex.W 13: 89 .byte 0x89 14: 74 24 je 0x3a [ 152.943953][ T250] RSP: 002b:00007ffe32604118 EFLAGS: 00000246 ORIG_RAX: 0000000000000001 [ 152.944217][ T250] RAX: ffffffffffffffda RBX: 0000000000000002 RCX: 00007f7080831b77 [ 152.944484][ T250] RDX: 0000000000000002 RSI: 0000561c1ffb0c10 RDI: 0000000000000001 [ 152.944737][ T250] RBP: 0000561c1ffb0c10 R08: 0000000000000000 R09: 00007f70808a44e0 [ 152.944986][ T250] R10: 00007f70808a43e0 R11: 0000000000000246 R12: 0000000000000002 [ 152.945268][ T250] R13: 00007f70808ed760 R14: 0000000000000002 R15: 00007f70808e89c0 | [ 152.949575][ T250] Disabling lock debugging due to kernel taint | [ 152.949804][ T250] Oops: general protection fault, probably for non-canonical address 0xf99995999999999c: 0000 [#1] PREEMPT SMP KASAN NOPTI | [ 152.950231][ T250] KASAN: maybe wild-memory-access in range [0xcccccccccccccce0-0xcccccccccccccce7] | [ 152.950842][ T250] Tainted: [B]=BAD_PAGE [ 152.950969][ T250] Hardware name: Bochs Bochs, BIOS Bochs 01/01/2011 [ 152.951178][ T250] RIP: 0010:page_pool_item_uninit (./arch/x86/include/asm/atomic.h:23 ./include/linux/atomic/atomic-arch-fallback.h:457 ./include/linux/atomic/atomic-instrumented.h:33 ./include/linux/refcount.h:136 net/core/page_pool.c:524) [ 152.951391][ T250] Code: 9c 48 bb 00 00 00 00 00 fc ff df 48 c1 ed 03 48 01 dd 4d 8d 75 1c be 04 00 00 00 4c 89 f7 e8 ad 6d 63 fe 4c 89 f0 48 c1 e8 03 <0f> b6 14 18 4c 89 f0 83 e0 07 83 c0 03 38 d0 7c 04 84 d2 75 62 41 All code ======== 0: 9c pushf 1: 48 bb 00 00 00 00 00 movabs $0xdffffc0000000000,%rbx 8: fc ff df b: 48 c1 ed 03 shr $0x3,%rbp f: 48 01 dd add %rbx,%rbp 12: 4d 8d 75 1c lea 0x1c(%r13),%r14 16: be 04 00 00 00 mov $0x4,%esi 1b: 4c 89 f7 mov %r14,%rdi 1e: e8 ad 6d 63 fe call 0xfffffffffe636dd0 23: 4c 89 f0 mov %r14,%rax 26: 48 c1 e8 03 shr $0x3,%rax 2a:* 0f b6 14 18 movzbl (%rax,%rbx,1),%edx <-- trapping instruction 2e: 4c 89 f0 mov %r14,%rax 31: 83 e0 07 and $0x7,%eax 34: 83 c0 03 add $0x3,%eax 37: 38 d0 cmp %dl,%al 39: 7c 04 jl 0x3f 3b: 84 d2 test %dl,%dl 3d: 75 62 jne 0xa1 3f: 41 rex.B Code starting with the faulting instruction =========================================== 0: 0f b6 14 18 movzbl (%rax,%rbx,1),%edx 4: 4c 89 f0 mov %r14,%rax 7: 83 e0 07 and $0x7,%eax a: 83 c0 03 add $0x3,%eax d: 38 d0 cmp %dl,%al f: 7c 04 jl 0x15 11: 84 d2 test %dl,%dl 13: 75 62 jne 0x77 15: 41 rex.B [ 152.951961][ T250] RSP: 0018:ffffc90000b974f0 EFLAGS: 00010a06 [ 152.952170][ T250] RAX: 199999999999999c RBX: dffffc0000000000 RCX: ffffffff9b29f6e3 [ 152.952419][ T250] RDX: 0000000000000000 RSI: 0000000000000004 RDI: cccccccccccccce0 [ 152.952666][ T250] RBP: fffffbfff3924c78 R08: 0000000000000000 R09: fffffbfff3cff688 [ 152.952911][ T250] R10: ffffffff9e7fb447 R11: 205d303532542020 R12: ffff888005351220 [ 152.953177][ T250] R13: ccccccccccccccc4 R14: cccccccccccccce0 R15: 0000000000000000 [ 152.953436][ T250] FS: 00007f70806f0740(0000) GS:ffff88806d080000(0000) knlGS:0000000000000000 [ 152.953732][ T250] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 152.953946][ T250] CR2: 00007f708084ecb0 CR3: 00000000096c8005 CR4: 0000000000772ef0 [ 152.954200][ T250] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 152.954461][ T250] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [ 152.954704][ T250] PKRU: 55555554 [ 152.954829][ T250] Call Trace: [ 152.954954][ T250] [ 152.955040][ T250] ? die_addr (arch/x86/kernel/dumpstack.c:421 arch/x86/kernel/dumpstack.c:460) [ 152.955167][ T250] ? exc_general_protection (arch/x86/kernel/traps.c:751 arch/x86/kernel/traps.c:693) [ 152.955333][ T250] ? asm_exc_general_protection (./arch/x86/include/asm/idtentry.h:617) [ 152.955503][ T250] ? page_pool_item_uninit (./arch/x86/include/asm/atomic.h:23 ./include/linux/atomic/atomic-arch-fallback.h:457 ./include/linux/atomic/atomic-instrumented.h:33 ./include/linux/refcount.h:136 net/core/page_pool.c:524) [ 152.955667][ T250] ? page_pool_item_uninit (./arch/x86/include/asm/atomic.h:23 ./include/linux/atomic/atomic-arch-fallback.h:457 ./include/linux/atomic/atomic-instrumented.h:33 ./include/linux/refcount.h:136 net/core/page_pool.c:524) [ 152.955832][ T250] page_pool_release (net/core/page_pool.c:1431 net/core/page_pool.c:1484) [ 152.955996][ T250] ? __pfx_autoremove_wake_function (kernel/sched/wait.c:383) [ 152.956202][ T250] ? __pfx_page_pool_release (net/core/page_pool.c:1478) [ 152.956364][ T250] ? napi_disable (./arch/x86/include/asm/bitops.h:75 ./include/asm-generic/bitops/instrumented-atomic.h:42 net/core/dev.c:6832) [ 152.956533][ T250] page_pool_destroy (net/core/page_pool.c:1555) [ 152.956699][ T250] nsim_stop (drivers/net/netdevsim/netdev.c:469 drivers/net/netdevsim/netdev.c:483) netdevsim [ 152.956875][ T250] __dev_close_many (net/core/dev.c:1591) [ 152.957038][ T250] ? __pfx___dev_close_many (net/core/dev.c:1555) [ 152.957203][ T250] ? __pfx_validate_chain (kernel/locking/lockdep.c:3860) [ 152.957369][ T250] ? hlock_class (./arch/x86/include/asm/bitops.h:227 ./arch/x86/include/asm/bitops.h:239 ./include/asm-generic/bitops/instrumented-non-atomic.h:142 kernel/locking/lockdep.c:228) [ 152.957535][ T250] ? mark_lock (kernel/locking/lockdep.c:4727 (discriminator 3)) [ 152.957661][ T250] ? hlock_class (./arch/x86/include/asm/bitops.h:227 ./arch/x86/include/asm/bitops.h:239 ./include/asm-generic/bitops/instrumented-non-atomic.h:142 kernel/locking/lockdep.c:228) [ 152.957827][ T250] dev_close_many (net/core/dev.c:1618) [ 152.957994][ T250] ? __pfx_dev_close_many (net/core/dev.c:1608) [ 152.958164][ T250] unregister_netdevice_many_notify (net/core/dev.c:11562) [ 152.958372][ T250] ? __mutex_trylock_common (./arch/x86/include/asm/atomic64_64.h:101 ./include/linux/atomic/atomic-arch-fallback.h:4296 ./include/linux/atomic/atomic-long.h:1482 ./include/linux/atomic/atomic-instrumented.h:4458 kernel/locking/mutex.c:104) [ 152.958536][ T250] ? __pfx___mutex_trylock_common (kernel/locking/mutex.c:79) [ 152.958740][ T250] ? __pfx_unregister_netdevice_many_notify (net/core/dev.c:11529) [ 152.958944][ T250] ? lock_acquire (kernel/locking/lockdep.c:5822) [ 152.959129][ T250] ? __mutex_lock (./arch/x86/include/asm/preempt.h:94 kernel/locking/mutex.c:595 kernel/locking/mutex.c:735) [ 152.959300][ T250] ? nsim_destroy (drivers/net/netdevsim/netdev.c:827) netdevsim [ 152.959477][ T250] ? __pfx___mutex_lock (kernel/locking/mutex.c:734) [ 152.959648][ T250] unregister_netdevice_queue (net/core/dev.c:11524) [ 152.959819][ T250] ? __pfx_do_raw_spin_lock (kernel/locking/spinlock_debug.c:114) [ 152.959987][ T250] ? __pfx_unregister_netdevice_queue (net/core/dev.c:11513) [ 152.960207][ T250] nsim_destroy (drivers/net/netdevsim/netdev.c:832 (discriminator 2)) netdevsim [ 152.960385][ T250] __nsim_dev_port_del (drivers/net/netdevsim/dev.c:426 drivers/net/netdevsim/dev.c:1429) netdevsim [ 152.960598][ T250] nsim_dev_reload_destroy (drivers/net/netdevsim/dev.c:1438 drivers/net/netdevsim/dev.c:1661) netdevsim [ 152.960809][ T250] nsim_drv_remove (drivers/net/netdevsim/dev.c:1678) netdevsim [ 152.960981][ T250] device_release_driver_internal (drivers/base/dd.c:1275 drivers/base/dd.c:1296) [ 152.961184][ T250] ? klist_put (lib/klist.c:220) [ 152.961308][ T250] bus_remove_device (./include/linux/kobject.h:193 drivers/base/base.h:73 drivers/base/bus.c:583) [ 152.961474][ T250] device_del (drivers/base/core.c:3855) [ 152.961601][ T250] ? __pfx_device_del (drivers/base/core.c:3809) [ 152.961765][ T250] ? lock_acquire.part.0 (kernel/locking/lockdep.c:467 kernel/locking/lockdep.c:5851) [ 152.961928][ T250] ? kernfs_fop_write_iter (fs/kernfs/file.c:326) [ 152.962094][ T250] device_unregister (drivers/base/core.c:3772 drivers/base/core.c:3896) [ 152.962261][ T250] del_device_store (drivers/net/netdevsim/bus.c:230) netdevsim [ 152.962470][ T250] ? __pfx_del_device_store (drivers/net/netdevsim/bus.c:197) netdevsim [ 152.962684][ T250] ? __pfx_sysfs_kf_write (fs/sysfs/file.c:132) [ 152.962846][ T250] ? sysfs_file_ops (fs/sysfs/file.c:31 (discriminator 1)) [ 152.963008][ T250] ? __pfx_sysfs_kf_write (fs/sysfs/file.c:132) [ 152.963198][ T250] kernfs_fop_write_iter (fs/kernfs/file.c:334) [ 152.963368][ T250] vfs_write (fs/read_write.c:586 fs/read_write.c:679) [ 152.963498][ T250] ? __pfx_vfs_write (fs/read_write.c:660) [ 152.963669][ T250] ? __lock_release (kernel/locking/lockdep.c:5525) [ 152.963835][ T250] ? do_user_addr_fault (./include/linux/rcupdate.h:347 ./include/linux/rcupdate.h:880 ./include/linux/mm.h:742 arch/x86/mm/fault.c:1340) [ 152.964010][ T250] ? __pfx___up_read (kernel/locking/rwsem.c:1337) [ 152.964181][ T250] ksys_write (fs/read_write.c:731) [ 152.964322][ T250] ? __pfx_ksys_write (fs/read_write.c:721) [ 152.964486][ T250] ? do_user_addr_fault (./include/linux/rcupdate.h:882 ./include/linux/mm.h:742 arch/x86/mm/fault.c:1340) [ 152.964652][ T250] do_syscall_64 (arch/x86/entry/common.c:52 arch/x86/entry/common.c:83) [ 152.964819][ T250] entry_SYSCALL_64_after_hwframe (arch/x86/entry/entry_64.S:130) [ 152.965024][ T250] RIP: 0033:0x7f7080831b77 [ 152.965195][ T250] Code: 0b 00 f7 d8 64 89 02 48 c7 c0 ff ff ff ff eb b7 0f 1f 00 f3 0f 1e fa 64 8b 04 25 18 00 00 00 85 c0 75 10 b8 01 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 51 c3 48 83 ec 28 48 89 54 24 18 48 89 74 24 All code ======== 0: 0b 00 or (%rax),%eax 2: f7 d8 neg %eax 4: 64 89 02 mov %eax,%fs:(%rdx) 7: 48 c7 c0 ff ff ff ff mov $0xffffffffffffffff,%rax e: eb b7 jmp 0xffffffffffffffc7 10: 0f 1f 00 nopl (%rax) 13: f3 0f 1e fa endbr64 17: 64 8b 04 25 18 00 00 mov %fs:0x18,%eax 1e: 00 1f: 85 c0 test %eax,%eax 21: 75 10 jne 0x33 23: b8 01 00 00 00 mov $0x1,%eax 28: 0f 05 syscall 2a:* 48 3d 00 f0 ff ff cmp $0xfffffffffffff000,%rax <-- trapping instruction 30: 77 51 ja 0x83 32: c3 ret 33: 48 83 ec 28 sub $0x28,%rsp 37: 48 89 54 24 18 mov %rdx,0x18(%rsp) 3c: 48 rex.W 3d: 89 .byte 0x89 3e: 74 24 je 0x64 Code starting with the faulting instruction =========================================== 0: 48 3d 00 f0 ff ff cmp $0xfffffffffffff000,%rax 6: 77 51 ja 0x59 8: c3 ret 9: 48 83 ec 28 sub $0x28,%rsp d: 48 89 54 24 18 mov %rdx,0x18(%rsp) 12: 48 rex.W 13: 89 .byte 0x89 14: 74 24 je 0x3a [ 152.965769][ T250] RSP: 002b:00007ffe32604118 EFLAGS: 00000246 ORIG_RAX: 0000000000000001 [ 152.966112][ T250] RAX: ffffffffffffffda RBX: 0000000000000002 RCX: 00007f7080831b77 [ 152.966367][ T250] RDX: 0000000000000002 RSI: 0000561c1ffb0c10 RDI: 0000000000000001 [ 152.966611][ T250] RBP: 0000561c1ffb0c10 R08: 0000000000000000 R09: 00007f70808a44e0 [ 152.966951][ T250] R10: 00007f70808a43e0 R11: 0000000000000246 R12: 0000000000000002 Finger prints: print_report:kasan_report:page_pool_item_uninit:page_pool_release:page_pool_destroy page_pool_item_uninit:page_pool_release:page_pool_destroy:nsim_stop:__dev_close_many